Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rulesets): add instance key to ruleset #384

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Conversation

wsan3
Copy link
Contributor

@wsan3 wsan3 commented Jul 9, 2024

Description

  • Add instance key to ruleset tag
  • Enable steps to match and run on certain instances (e.g. dev vs prod)

Example

version: "1"

steps:
  - name: run step on production instance
    ruleset:
      event: push
      branch: main
      instance: https://octocat.prod.github.com
    image: alpine
    commands:
      - echo "this step ran on a production instance"

Related

go-vela/community#803

@wsan3 wsan3 added the feature Indicates a new feature label Jul 9, 2024
@wsan3 wsan3 self-assigned this Jul 9, 2024
@wsan3 wsan3 requested a review from a team as a code owner July 9, 2024 18:30
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 93.54839% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.05%. Comparing base (75a4808) to head (94492cc).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #384      +/-   ##
==========================================
- Coverage   96.08%   96.05%   -0.03%     
==========================================
  Files          69       69              
  Lines        5365     5375      +10     
==========================================
+ Hits         5155     5163       +8     
- Misses        136      137       +1     
- Partials       74       75       +1     
Files Coverage Δ
pipeline/container.go 81.45% <100.00%> (+0.24%) ⬆️
yaml/ruleset.go 100.00% <100.00%> (ø)
pipeline/ruleset.go 80.58% <71.42%> (-1.24%) ⬇️

@wsan3 wsan3 merged commit d47730b into main Aug 1, 2024
10 of 11 checks passed
@wsan3 wsan3 deleted the feat/ruleset-instance branch August 1, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Indicates a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants