Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update golangci config and clean repo #53

Merged
merged 3 commits into from
Mar 9, 2022
Merged

chore: update golangci config and clean repo #53

merged 3 commits into from
Mar 9, 2022

Conversation

kaymckay
Copy link
Contributor

@kaymckay kaymckay commented Mar 4, 2022

No description provided.

@kaymckay kaymckay self-assigned this Mar 4, 2022
@codecov
Copy link

codecov bot commented Mar 4, 2022 •
edited
Loading

Codecov Report

Merging #53 (770b7f8) into master (29aba92) will increase coverage by 0.82%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage   62.89%   63.71%   +0.82%     
==========================================
  Files           7        7              
  Lines         671      667       -4     
==========================================
+ Hits          422      425       +3     
+ Misses        241      236       -5     
+ Partials        8        6       -2
Impacted Files Coverage Δ
cmd/vela-docker/main.go 0.00% <0.00%> (ø)
cmd/vela-docker/registry.go 100.00% <ø> (ø)
cmd/vela-docker/daemon.go 75.96% <66.66%> (+0.48%) ⬆️
cmd/vela-docker/build.go 97.26% <100.00%> (+1.35%) ⬆️
cmd/vela-docker/push.go 96.42% <100.00%> (+10.22%) ⬆️

@kaymckay kaymckay marked this pull request as ready for review March 4, 2022 20:35
@kaymckay kaymckay requested a review from a team as a code owner March 4, 2022 20:35
KellyMerrick
KellyMerrick approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kaymckay kaymckay requested review from a team March 8, 2022 01:32
@kaymckay kaymckay merged commit 8c9849c into master Mar 9, 2022
@kaymckay kaymckay deleted the golangci-config branch March 9, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wass3r wass3r wass3r approved these changes

@KellyMerrick KellyMerrick KellyMerrick approved these changes

Assignees

@kaymckay kaymckay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaymckay @wass3r @KellyMerrick