fixing secret mask bug

go-vela · Feb 18, 2022 · 5848867 · 5848867
1 parent 786296f
commit 5848867
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/executor/linux/step.go b/executor/linux/step.go
@@ -464,7 +464,11 @@ func getSecretValues(ctn *pipeline.Container) []string {
 	secretValues := []string{}
 	// gather secrets' values from the environment map for masking
 	for _, secret := range ctn.Secrets {
-		s := ctn.Environment[strings.ToUpper(secret.Target)]
+		// capture secret from environment
+		s, ok := ctn.Environment[strings.ToUpper(secret.Target)]
+		if !ok {
+			continue
+		}
 		// handle multi line secrets from files
 		s = strings.ReplaceAll(s, "\n", " ")
 

diff --git a/executor/linux/step_test.go b/executor/linux/step_test.go
@@ -570,6 +570,10 @@ func TestLinux_getSecretValues(t *testing.T) {
 						Source: "someOtherSource",
 						Target: "secret_password",
 					},
+					{
+						Source: "disallowedSecret",
+						Target: "cannot_find",
+					},
 				},
 			},
 		},