Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(kubernetes): Refactor watch related code #288

Merged
merged 6 commits into from
Mar 15, 2022
Merged

refactor(kubernetes): Refactor watch related code #288

merged 6 commits into from
Mar 15, 2022

Commits on Mar 14, 2022

  1. Extract Kubernetes Client + Watch mocking logic

    @cognifloyd
    cognifloyd committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    f8e8781 View commit details
    Browse the repository at this point in the history

  2. Move newMockWithWatch to kubernetes_test.go

    @cognifloyd
    cognifloyd committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    fd36c34 View commit details
    Browse the repository at this point in the history

  3. Rename watch->podWatch for clarity 

    Also, a future commit/PR wil (probably) import
"k8s.io/apimachinery/pkg/watch" which would coflict with local vars
named "watch".
    @cognifloyd
    cognifloyd committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    73fdd29 View commit details
    Browse the repository at this point in the history

  4. Close the podWatch in WaitContainer

    @cognifloyd
    cognifloyd committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    5d72207 View commit details
    Browse the repository at this point in the history

  5. Escape selector just in case 

    In reviewing some of the go-client code, I noticed that label selectors
were escaped. So, I am doing that here. I don't know of any issues that
this catches.
    @cognifloyd
    cognifloyd committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    a1fb4d0 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2022

  1. Merge branch 'master' into extract-k8s-mock-with-watch

    @wass3r
    wass3r authored Mar 15, 2022
    Configuration menu
    Copy the full SHA
    79d327d View commit details
    Browse the repository at this point in the history