Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(logging): add info log prior to each download/use of an image during init step #579

Merged
merged 2 commits into from
May 13, 2024

Conversation

wsan3
Copy link
Contributor

@wsan3 wsan3 commented May 13, 2024

Description

Add an informational log prior to each download/use of an image during the initialization step of a build for visibility.

Desired View: Vela UI

Screenshot 2024-05-13 at 12 10 37 PM

Desired View: Local Execution

Screenshot 2024-05-13 at 12 14 40 PM

Related

go-vela/community#915

@wsan3 wsan3 added the enhancement Indicates an improvement to a feature label May 13, 2024
@wsan3 wsan3 self-assigned this May 13, 2024
@wsan3 wsan3 requested a review from a team as a code owner May 13, 2024 17:29
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.01%. Comparing base (547041b) to head (9075043).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #579      +/-   ##
==========================================
+ Coverage   57.96%   58.01%   +0.05%     
==========================================
  Files         120      120              
  Lines        4996     5002       +6     
==========================================
+ Hits         2896     2902       +6     
  Misses       1898     1898              
  Partials      202      202              
Files Coverage Δ
executor/linux/build.go 75.12% <100.00%> (+0.12%) ⬆️
executor/linux/stage.go 79.26% <100.00%> (+0.25%) ⬆️
executor/local/build.go 75.66% <100.00%> (+0.26%) ⬆️
executor/local/stage.go 79.62% <100.00%> (+0.38%) ⬆️

Copy link
Contributor

@ecrupper ecrupper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@wsan3 wsan3 merged commit acf42e2 into main May 13, 2024
13 of 16 checks passed
@wsan3 wsan3 deleted the enhance/logging-image-prep branch May 13, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates an improvement to a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants