Port Succo's fix to cache decodeHooks #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is awesome! 3x improvement on a real life code. |
|
@sagikazarmark Any chance you could help us get this reviewed and merged? It'd be really great to get this fix upstream so we can stop relying on a fork. Thanks! |
|
@cedric-cordenier of course! Would you mind rebasing/force pushing to trigger CI? Also, could you please link the original PR here for future reference? Thank you! |
|
Thanks @sagikazarmark, greatly appreciated! 🙏 The original PR is here: mitchellh#324 I've just merged main back into my branch. Let me know if you need me to do anything else :) |
codeboten
referenced
this pull request
in open-telemetry/opentelemetry-collector
Aug 13, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/go-viper/mapstructure/v2](https://togithub.com/go-viper/mapstructure) | `v2.0.0` -> `v2.1.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>go-viper/mapstructure (github.com/go-viper/mapstructure/v2)</summary> ### [`v2.1.0`](https://togithub.com/go-viper/mapstructure/releases/tag/v2.1.0) [Compare Source](https://togithub.com/go-viper/mapstructure/compare/v2.0.0...v2.1.0) #### What's Changed - build(deps): bump actions/setup-go from 5.0.0 to 5.0.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/go-viper/mapstructure/pull/28](https://togithub.com/go-viper/mapstructure/pull/28) - build(deps): bump actions/checkout from 4.1.1 to 4.1.6 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/go-viper/mapstructure/pull/27](https://togithub.com/go-viper/mapstructure/pull/27) - build(deps): bump golangci/golangci-lint-action from 3.7.0 to 6.0.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/go-viper/mapstructure/pull/26](https://togithub.com/go-viper/mapstructure/pull/26) - build(deps): bump actions/setup-go from 5.0.1 to 5.0.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/go-viper/mapstructure/pull/34](https://togithub.com/go-viper/mapstructure/pull/34) - build(deps): bump actions/checkout from 4.1.6 to 4.1.7 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/go-viper/mapstructure/pull/29](https://togithub.com/go-viper/mapstructure/pull/29) - Port Succo's fix to cache decodeHooks by [@​cedric-cordenier](https://togithub.com/cedric-cordenier) in [https://github.com/go-viper/mapstructure/pull/33](https://togithub.com/go-viper/mapstructure/pull/33) - build(deps): bump golangci/golangci-lint-action from 6.0.1 to 6.1.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/go-viper/mapstructure/pull/38](https://togithub.com/go-viper/mapstructure/pull/38) - Add configuration option to specify tag value that indicates squash by [@​triarius](https://togithub.com/triarius) in [https://github.com/go-viper/mapstructure/pull/18](https://togithub.com/go-viper/mapstructure/pull/18) - Adding support for squash: interface. by [@​m1k1o](https://togithub.com/m1k1o) in [https://github.com/go-viper/mapstructure/pull/17](https://togithub.com/go-viper/mapstructure/pull/17) #### New Contributors - [@​dependabot](https://togithub.com/dependabot) made their first contribution in [https://github.com/go-viper/mapstructure/pull/28](https://togithub.com/go-viper/mapstructure/pull/28) - [@​cedric-cordenier](https://togithub.com/cedric-cordenier) made their first contribution in [https://github.com/go-viper/mapstructure/pull/33](https://togithub.com/go-viper/mapstructure/pull/33) - [@​triarius](https://togithub.com/triarius) made their first contribution in [https://github.com/go-viper/mapstructure/pull/18](https://togithub.com/go-viper/mapstructure/pull/18) - [@​m1k1o](https://togithub.com/m1k1o) made their first contribution in [https://github.com/go-viper/mapstructure/pull/17](https://togithub.com/go-viper/mapstructure/pull/17) **Full Changelog**: go-viper/mapstructure@v2.0.0...v2.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/open-telemetry/opentelemetry-collector). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yMC4xIiwidXBkYXRlZEluVmVyIjoiMzguMjAuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIiwicmVub3ZhdGVib3QiXX0=--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
nono
referenced
this pull request
in cozy/cozy-stack
Sep 18, 2024
](https://renovatebot.com){kind=link}
#4464) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/go-viper/mapstructure/v2](https://redirect.github.com/go-viper/mapstructure) | `v2.0.0` -> `v2.1.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>go-viper/mapstructure (github.com/go-viper/mapstructure/v2)</summary> ### [`v2.1.0`](https://redirect.github.com/go-viper/mapstructure/releases/tag/v2.1.0) [Compare Source](https://redirect.github.com/go-viper/mapstructure/compare/v2.0.0...v2.1.0) #### What's Changed - build(deps): bump actions/setup-go from 5.0.0 to 5.0.1 by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/go-viper/mapstructure/pull/28](https://redirect.github.com/go-viper/mapstructure/pull/28) - build(deps): bump actions/checkout from 4.1.1 to 4.1.6 by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/go-viper/mapstructure/pull/27](https://redirect.github.com/go-viper/mapstructure/pull/27) - build(deps): bump golangci/golangci-lint-action from 3.7.0 to 6.0.1 by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/go-viper/mapstructure/pull/26](https://redirect.github.com/go-viper/mapstructure/pull/26) - build(deps): bump actions/setup-go from 5.0.1 to 5.0.2 by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/go-viper/mapstructure/pull/34](https://redirect.github.com/go-viper/mapstructure/pull/34) - build(deps): bump actions/checkout from 4.1.6 to 4.1.7 by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/go-viper/mapstructure/pull/29](https://redirect.github.com/go-viper/mapstructure/pull/29) - Port Succo's fix to cache decodeHooks by [@​cedric-cordenier](https://redirect.github.com/cedric-cordenier) in [https://github.com/go-viper/mapstructure/pull/33](https://redirect.github.com/go-viper/mapstructure/pull/33) - build(deps): bump golangci/golangci-lint-action from 6.0.1 to 6.1.0 by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/go-viper/mapstructure/pull/38](https://redirect.github.com/go-viper/mapstructure/pull/38) - Add configuration option to specify tag value that indicates squash by [@​triarius](https://redirect.github.com/triarius) in [https://github.com/go-viper/mapstructure/pull/18](https://redirect.github.com/go-viper/mapstructure/pull/18) - Adding support for squash: interface. by [@​m1k1o](https://redirect.github.com/m1k1o) in [https://github.com/go-viper/mapstructure/pull/17](https://redirect.github.com/go-viper/mapstructure/pull/17) #### New Contributors - [@​dependabot](https://redirect.github.com/dependabot) made their first contribution in [https://github.com/go-viper/mapstructure/pull/28](https://redirect.github.com/go-viper/mapstructure/pull/28) - [@​cedric-cordenier](https://redirect.github.com/cedric-cordenier) made their first contribution in [https://github.com/go-viper/mapstructure/pull/33](https://redirect.github.com/go-viper/mapstructure/pull/33) - [@​triarius](https://redirect.github.com/triarius) made their first contribution in [https://github.com/go-viper/mapstructure/pull/18](https://redirect.github.com/go-viper/mapstructure/pull/18) - [@​m1k1o](https://redirect.github.com/m1k1o) made their first contribution in [https://github.com/go-viper/mapstructure/pull/17](https://redirect.github.com/go-viper/mapstructure/pull/17) **Full Changelog**: go-viper/mapstructure@v2.0.0...v2.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 6am on Monday" in timezone Europe/Paris, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/cozy/cozy-stack). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC43NC4xIiwidXBkYXRlZEluVmVyIjoiMzguNzQuMSIsInRhcmdldEJyYW5jaCI6Im1hc3RlciIsImxhYmVscyI6W119-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like @Succo we are seeing a big performance hit from typedDecodeHook being called repeatedly.
Fixes #30