Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url before the anchor #24

Closed
maieul opened this issue Aug 14, 2019 · 2 comments
Closed

url before the anchor #24

maieul opened this issue Aug 14, 2019 · 2 comments
Assignees
@goblindegook
Labels
bug

Comments

@maieul
Copy link

maieul commented Aug 14, 2019

Some CMS add an url before the anchor for the footnote.

That make a markup like this

<!DOCTYPE html>
<html>
<head>
<link rel="stylesheet" href="https://unpkg.com/littlefoot/dist/littlefoot.css">
</head>
<body>
<!-- Links -->
<p>
  <sup id="fnref:1">
    <a href="index.html#fn:1" rel="footnote">1</a>
  </sup>
</p>

<!-- Footnote List -->
<div class="footnotes">
  <ol>
    <li class="footnote" id="fn:1">
      <p>footnote. <a href="#fnref:1" title="return to article"> ↩</a></p>
      <p></p>
    </li>
  </ol>
</div>
<script src="https://unpkg.com/littlefoot/dist/littlefoot.min.js" type="application/javascript"></script>
<script type="application/javascript">
  littlefoot.default()
</script>
</body>
</html>

Supposing the file is called "index.html". While bigfoot was able to manage this case, that is not true for littlefoot.
@goblindegook goblindegook self-assigned this Aug 14, 2019
@goblindegook
Copy link
Owner

Thanks for reporting this, it seems like a bug, will investigate.

goblindegook added a commit that referenced this issue Aug 14, 2019
@goblindegook
fix: footnote detection whose links contain a URL before the fragment
2e24293 
#24
@goblindegook
Copy link
Owner

Fixed in 3.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@goblindegook goblindegook

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@goblindegook @maieul