Update CI configuration #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WGH-
force-pushed
the
fix-ci
branch
2 times, most recently
from
384e414
to
739b0d3
Compare
The result of running `go fmt ./...`. See [1] for details. [1] https://go.dev/doc/go1.19#go-doc
Upstream supports 1.19 and 1.18 right now, but let's be generous and also include 1.17. This should fix CI, since Colly can't be build properly on 1.15 and older, and it has been this way for a while. As of go install change, it's the correct way to install tools since Go 1.16[1]. [1] https://go.dev/doc/go1.16#modules
This is a cleaner way than checking output.
asciimoo
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream supports 1.19 and 1.18 right now, but let's be generous and also include 1.17.
This should fix CI, since Colly can't be built properly on 1.15 and older, and it has been this way for a while.
Also enable CI runs for pull requests, as it's good to know whether they're ok or not, and GitHub Actions are free anyway.