Improve Dynamic HR block stability through E2E testing #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanHerman
added
[Type] Enhancement
EvanHerman
requested review from
AnthonyLedesma,
jrtashjian and
richtabor
as code owners
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
AnthonyLedesma
requested changes
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New E2E tests for the Dynamic HR block
Other Changes
helpers.getBlockName()to remove-in favor of a empty spacehelpers.hexToRGB()to convert hex strings to RGB strings for CSS comparison checks in cypress.helpers.capitalize()to capitalize the first letters of each word in a string. eg:hello world=>Hello World. This is used when setting up the posts so the page title is set properly.