Only load front end CSS when it is needed #1455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This checks to make sure that a Coblock is being used before requiring the CSS to be loaded on the front end of the site. This is to address godaddy-wordpress#1454 In my basic tests this worked fine, however I'd like to see it get broader testing to make sure I haven't missed other conditions.
josephscott
requested review from
AnthonyLedesma,
EvanHerman,
jrtashjian and
richtabor
as code owners
|
Good stuff, we'll run it though some testing. I'll hand this to you @jrtashjian. Should work find, though we'll need to make sure the assets load on index/archive views. |
richtabor
added
[Priority] Low
|
@richtabor / @jrtashjian - any thoughts on when this could be reviewed and included in a new release? |
|
Hey @josephscott, I’m planning to review this during the current release cycle. If all looks/works well (which at first glance it does) then it’ll make it into the release next Thursday. |
|
Sounds good! |
jrtashjian
approved these changes
Apr 30, 2020
|
Closes #1454 |
jrtashjian
added
the
[Status] Ready to Merge
jrtashjian
removed
the
[Status] In Progress
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checks to make sure that a Coblock is being used before requiring the CSS to be loaded on the front end of the site. This is to address #1454
In my basic tests this worked fine, however I'd like to see it get broader testing to make sure I haven't missed other conditions.