Allow HTML formatted text within Lightbox captions #1566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchwenger
requested review from
AnthonyLedesma,
EvanHerman,
jrtashjian and
richtabor
as code owners
richtabor
added
[Status] Needs Review
|
Awesome work here @jchwenger. Your changes uncovered a superior method of implementing this fix. I made a minor tweak to the JavaScript and location of change which allows users to keep the formatted text within the lightbox.
I've also taken the liberty to add your GitHub username to the CONTRIBUTORS.md file for CoBlocks. I was not able to locate a WordPress.org username for you to add to the document so let us know or submit a PR for that change if you would like. Thank you for taking time to help make CoBlocks awesome! |
AnthonyLedesma
approved these changes
Jul 13, 2020
AnthonyLedesma
changed the title
|
Grand, I thought something of that kind could be done, and tried something close which didn't work, during my tests. Indeed no real WP.org account at this point... Pleasure in any case, looking forward to the next release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Only extracts plain text and converts html code (e.g. &) into text before injecting it into lightbox captions.
Types of changes
Only
textContentinstead ofrawHTMLhere.However, that means that no html code can be used in said captions, e.g. bold, italics. I have been looking for a way to achieve that, maybe that could be implemented in the future.
How has this been tested?
Implemented it on the website I'm currently working on.
Checklist:
Closes #1558