Layout selector performance improvements #1577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrtashjian
added
[Type] Enhancement
richtabor
reviewed
Jul 20, 2020
richtabor
reviewed
Jul 20, 2020
richtabor
reviewed
Jul 20, 2020
jrtashjian
added
[Status] Needs Review
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Failures
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||||||||||||||||||
jrtashjian
requested review from
AnthonyLedesma and
EvanHerman
as code owners
jrtashjian
requested review from
jonathanbardo
and removed request for
EvanHerman and
AnthonyLedesma
|
@jrtashjian Can you take a look at the conflict? Pretty sure it's only because we took out image fetch. |
jonathanbardo
previously requested changes
Nov 3, 2020
jrtashjian
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The way we were using the BlockPreview component from Gutenberg was very slow when loading more than 5 previews in a list. With the release of Block Patterns in Gutenberg I've recognized performance improvements that were made in core where they BlockPreview component was being used inth block inserter. This PR takes those findings and implements them here.
The result is a more snappy interaction when interacting with the previews and no delay in interacting with the layout selector while previews load.
Types of changes
Enhancement
How has this been tested?
This has been tested manually with 1, 5, 10, 20, 50, and 100 layouts being added through the available filters in PHP.
Checklist: