Fix Accordion block appender behavior #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olafleur
requested review from
AnthonyLedesma,
EvanHerman and
jrtashjian
as code owners
jonathanbardo
approved these changes
Mar 15, 2021
There was a problem hiding this comment.
@olafleur 👏 Thank you! I tested your CyPress fix and it does indeed highlight the bug quite nicely.
AnthonyLedesma
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a proposed fix for #1768
Types of changes
Bug fix
How has this been tested?
The automated test was only triggering the onMouseUp event. When you change it to a full click event in the test, it reproduce the error in the issue.
I have changed the onMouseUp event in the component to on MouseDown and it fixes the test and the behavior, from what I see.
Checklist: