Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce WordPress 5.8 compatiblity #1923

Merged
merged 54 commits into from
Jul 2, 2021
Merged

Introduce WordPress 5.8 compatiblity #1923

merged 54 commits into from
Jul 2, 2021

Conversation

olafleur
Copy link
Member

No description provided.

olafleur-godaddy and others added 26 commits June 11, 2021 08:41
@olafleur olafleur marked this pull request as draft June 17, 2021 17:55
@AnthonyLedesma AnthonyLedesma mentioned this pull request Jun 29, 2021
Closed
@AnthonyLedesma AnthonyLedesma changed the title Coblocks compatibility with Wordpress 5.8 (WIP) CoBlocks WordPress 5.8 Support Jun 29, 2021
@AnthonyLedesma AnthonyLedesma added [Status] Needs Review Tracking pull requests that need another set of eyes [Status] Do Not Merge Issues/PRs that should not be merged (yet) and removed [Status] In Progress Tracking issues with work in progress [Status] Do Not Merge Issues/PRs that should not be merged (yet) labels Jun 29, 2021
@AnthonyLedesma AnthonyLedesma linked an issue Jun 29, 2021 that may be closed by this pull request
ISBAT E2E test the Author block across browsers #1495
Closed
@AnthonyLedesma
Copy link
Member

I've linked #1495 to be closed with this PR as a solution has been introduced.

@olafleur olafleur requested a review from ehamwey July 1, 2021 05:01
@AnthonyLedesma AnthonyLedesma marked this pull request as ready for review July 1, 2021 13:58
@AnthonyLedesma AnthonyLedesma dismissed ehamwey’s stale review July 1, 2021 15:12

Reverted CI changes.

@AnthonyLedesma
Copy link
Member

AnthonyLedesma commented Jul 1, 2021 •
edited
Loading

These changes are verified as backward compatible by creating CI pipelines to test against 5.8 nightly as well as 5.7.2. Test results can be seen here:
https://dashboard.cypress.io/projects/sovnn2/runs/1396/overview
772 passing e2e tests.
image

The CI changes have been reverted for this PR.

ehamwey
ehamwey reviewed Jul 1, 2021
View reviewed changes
Copy link
Contributor

@ehamwey ehamwey left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Just to make sure since I didn't see it in my review - we already reverted the cypress config changes and fixes for the polyfills, right?

Edit: Just saw your above comment. LGTM.

@AnthonyLedesma AnthonyLedesma added [Status] Waiting Issues/PRs that are on hold and removed [Status] Needs Review Tracking pull requests that need another set of eyes labels Jul 1, 2021
@AnthonyLedesma
Copy link
Member

I suspect that this PR should be held until additional testing can be done for Release Candidate. Added waiting label until that status changes.

@AnthonyLedesma AnthonyLedesma changed the title CoBlocks WordPress 5.8 Support Introduce WordPress 5.8 compatiblity Jul 2, 2021
@AnthonyLedesma AnthonyLedesma removed the [Status] Do Not Merge Issues/PRs that should not be merged (yet) label Jul 2, 2021
@AnthonyLedesma AnthonyLedesma self-assigned this Jul 2, 2021
@AnthonyLedesma AnthonyLedesma added this to the Next Release milestone Jul 2, 2021
@AnthonyLedesma AnthonyLedesma merged commit ff1ddc3 into master Jul 2, 2021
@AnthonyLedesma AnthonyLedesma deleted the WPEX-1328-run-all-tests branch July 2, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnthonyLedesma AnthonyLedesma AnthonyLedesma left review comments

@ehamwey ehamwey ehamwey approved these changes

Assignees

@AnthonyLedesma AnthonyLedesma

Labels
[Status] Waiting Issues/PRs that are on hold
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.

ISBAT E2E test the Author block across browsers
4 participants
@olafleur @AnthonyLedesma @ehamwey @olafleur-godaddy