Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with WP 6.4 #2568

Merged
merged 40 commits into from
Oct 31, 2023
Merged

Compatibility with WP 6.4 #2568

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
c61b063
Remove scaffolding for WP 6.3
olafleur-godaddy Sep 18, 2023
8322342
Do not test on 6.2 anymore
olafleur-godaddy Sep 18, 2023
07d2d85
Fix Pricing Table Item test
olafleur-godaddy Sep 27, 2023
e141350
try something else
olafleur-godaddy Sep 27, 2023
cc2b3f6
not yet 6.4
olafleur-godaddy Sep 27, 2023
7612728
Merge branch 'master' into WP64-compat
olafleur-godaddy Oct 3, 2023
ce35d5c
Skip two layout selector tests for the moment
olafleur-godaddy Oct 11, 2023
1d3a211
Forgot a skip
olafleur-godaddy Oct 11, 2023
68882d2
try using new workflow
aledesma-godaddy Oct 20, 2023
937c50d
add a step to flow
aledesma-godaddy Oct 20, 2023
de3a61e
try more flows
aledesma-godaddy Oct 20, 2023
346c08d
reference workflow version
aledesma-godaddy Oct 20, 2023
3f18c56
correct path for workflows
aledesma-godaddy Oct 20, 2023
7aa2537
remove version :|
aledesma-godaddy Oct 20, 2023
570e8cc
correct variable naming
aledesma-godaddy Oct 20, 2023
d17998a
more workflow changes
aledesma-godaddy Oct 20, 2023
aaa064e
fix syntax for npx command
aledesma-godaddy Oct 20, 2023
8e87eab
allow custom path on e2e
aledesma-godaddy Oct 20, 2023
436f5a5
Merge branch 'master' into WP64-compat
AnthonyLedesma Oct 20, 2023
082e5d3
try pricing refactor
aledesma-godaddy Oct 20, 2023
4df5272
refactors to pricing table and update deps for tests
aledesma-godaddy Oct 24, 2023
6199353
update the deps and tests
aledesma-godaddy Oct 24, 2023
80ef230
apply mass lint fixes & composer deps update
aledesma-godaddy Oct 24, 2023
5744e52
test against 6.4rc2 now
aledesma-godaddy Oct 25, 2023
86488d4
debug workflow
aledesma-godaddy Oct 26, 2023
b61fb6a
add theme to wp next testing
aledesma-godaddy Oct 26, 2023
ef38fd9
fix layout selector tests and run all tests
aledesma-godaddy Oct 26, 2023
15cc800
update workflow logic
aledesma-godaddy Oct 26, 2023
2321fdf
bug fix in unit test matrix
aledesma-godaddy Oct 26, 2023
13fbcd3
update test selectors for backward compat
aledesma-godaddy Oct 27, 2023
f9028b3
fix helper logic
aledesma-godaddy Oct 27, 2023
945854a
improvements around test workflows and fix media filter tests
aledesma-godaddy Oct 27, 2023
39d965c
workflow logic
aledesma-godaddy Oct 27, 2023
70b828e
try to fix that race conditon in when inserting and selecting blocks
aledesma-godaddy Oct 30, 2023
5b067e6
more selectors in helpers
aledesma-godaddy Oct 30, 2023
c03da06
Merge branch 'master' into WP64-compat
AnthonyLedesma Oct 31, 2023
f32da23
bump to rc3
aledesma-godaddy Oct 31, 2023
6a489a2
oh right, rc3 is out tomorrow
aledesma-godaddy Oct 31, 2023
c642a36
fix block deprecation, typo fixes
aledesma-godaddy Oct 31, 2023
8d67d51
css fix
aledesma-godaddy Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update test selectors for backward compat
  • Loading branch information
@aledesma-godaddy
aledesma-godaddy committed Oct 27, 2023
commit 13fbcd38d8244d98fe561b1b343d397094a4fa96
9 changes: 7 additions & 2 deletions .dev/tests/cypress/helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,6 +408,11 @@ export const upload = {
},
};

const customColorPalatteSelector = ( () => [
'.components-color-palette__custom-color-button', // WP 6.3+
'.components-color-palette__custom-color', // WP 6.2.
] )();

/**
* Set a Color Setting value to a custom hex color
*
Expand All @@ -419,7 +424,7 @@ export function setColorSettingsFoldableSetting( settingName, hexColor ) {

cy.get( '.block-editor-panel-color-gradient-settings__dropdown' ).contains( settingName, { matchCase: false } ).click();

cy.get( '.components-color-palette__custom-color-button' ).click();
cy.get( customColorPalatteSelector ).click();

cy.get( '.components-color-picker' ).find( '.components-input-control__input' ).click().clear().type( formattedHex );

Expand All @@ -433,7 +438,7 @@ export function setColorPanelSetting( settingName, hexColor ) {

cy.get( '.block-editor-panel-color-gradient-settings__dropdown' ).contains( settingName, { matchCase: false } ).click();

cy.get( '.components-color-palette__custom-color-button' ).click();
cy.get( customColorPalatteSelector ).click();

cy.get( '.components-color-picker' ).find( '.components-input-control__input' ).click().clear().type( formattedHex );

Expand Down
9 changes: 7 additions & 2 deletions src/blocks/gallery-masonry/test/gallery-masonry.cypress.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,13 +156,18 @@ describe( 'Test CoBlocks Gallery Masonry Block', function() {

helpers.selectBlock( 'image' );

cy.get( '.block-editor-block-toolbar div:nth-of-type(5) button:not(.has-icon)' ).click();
const replaceImageSelectors = ( () => [
'.block-editor-block-toolbar div:nth-of-type(5) button:not(.has-icon)', // WP 6.3 +.
'.block-editor-block-toolbar div:nth-of-type(4) button:not(.has-icon)', // WP 6.2.
].join() )();

cy.get( replaceImageSelectors ).click();

cy.get( '.components-popover__content' ).should( 'be.visible' );

cy.get( '.block-editor-media-replace-flow__media-upload-menu .components-menu-item__button' ).contains( 'Open Media Library' );

cy.get( '.block-editor-block-toolbar div:nth-of-type(5) button:not(.has-icon)' ).click();
cy.get( replaceImageSelectors ).click();

cy.get( 'figure[data-type="coblocks/gallery-masonry"]' ).click();

Expand Down
Loading