Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Lightbox compatibility with Lazy Loading #2588

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

AnthonyLedesma
Copy link
Member

Description

Fixes #2582

Enhance the Lightbox script logic to allow for Lightbox with A3 Lazy Load plugin.
Source the image from data-src attribute if the src contains 'lazy-load'.

Screenshots

LightBoxLazyLoad

Types of changes

Lightbox JavaScript changes.

How has this been tested?

Tested manually.

Acceptance criteria

Should allow Lightbox to function when A3 Lazy Load is enabled.

Checklist:

  • My code is tested
  • My code follows accessibility standards
  • My code has proper inline documentation
  • I've included any necessary tests
  • I've included developer documentation
  • I've added proper labels to this pull request

@AnthonyLedesma AnthonyLedesma added [Status] Needs Review Tracking pull requests that need another set of eyes javascript Pull requests that update Javascript code labels Feb 27, 2024
@AnthonyLedesma AnthonyLedesma self-assigned this Feb 27, 2024
@EvanHerman EvanHerman self-requested a review February 27, 2024 19:48
Copy link
Contributor

@EvanHerman EvanHerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@AnthonyLedesma AnthonyLedesma merged commit 1610ba4 into master Feb 27, 2024
48 checks passed
@AnthonyLedesma AnthonyLedesma deleted the lightbox-lazy-compat branch February 27, 2024 20:16
@AnthonyLedesma AnthonyLedesma added this to the Next Release milestone Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code [Status] Needs Review Tracking pull requests that need another set of eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I am not able to use Lightbox in Masonry Gallery
3 participants