Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve error with Site Design failing DOM operations. #2610

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

AnthonyLedesma
Copy link
Member

@AnthonyLedesma AnthonyLedesma commented Apr 29, 2024

Description

The Site Design component has some logic that is responsible for moving Style elements. Changes in versions of WordPress over time had made the previous logic incompatible.

Screenshots

Before
Screenshot 2024-04-29 at 2 35 20 PM

After
Screenshot 2024-04-29 at 2 38 49 PM

Types of changes

Changes here to selectors. This change should prevent the same error from occurring in the future.

How has this been tested?

Tested manually in Managed WordPress hosting.

Acceptance criteria

Should resolve the error with Site Design in the post editor.

Checklist:

  • My code is tested
  • My code follows accessibility standards
  • My code has proper inline documentation
  • I've included any necessary tests
  • I've included developer documentation
  • I've added proper labels to this pull request

@AnthonyLedesma AnthonyLedesma self-assigned this Apr 29, 2024
@AnthonyLedesma AnthonyLedesma added this to the Next Release milestone Apr 29, 2024
Copy link
Contributor

@EvanHerman EvanHerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@AnthonyLedesma AnthonyLedesma merged commit 3e76e75 into master Apr 30, 2024
40 checks passed
@AnthonyLedesma AnthonyLedesma deleted the WPEX-3682 branch April 30, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants