Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disappearing buttons inside of Services blocks #2613

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

jgutierrezmoren-godaddy
Copy link
Contributor

Description

Removed 'Display button' toggle from the services and service blocks.
Link to issue WPEX-3677

Types of changes

Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Manual regression testing

Acceptance criteria

'Display button' toggle should be completely removed after deciding to allow users to place buttons within the inner blocks if they choose.

Checklist:

  • Code is tested so that the removed feature does not introduce any issues

@jgutierrezmoren-godaddy jgutierrezmoren-godaddy added First-time Contributor Pull request opened by a first-time contributor javascript Pull requests that update Javascript code labels Jun 10, 2024
@snovosel-godaddy snovosel-godaddy requested review from snovosel-godaddy and removed request for snovosel June 10, 2024 15:00
Copy link
Member

@AnthonyLedesma AnthonyLedesma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test must be changed

/**
* Test that we can add a services block to the content, enable
* action buttons and are able to successfully save the block without errors.
*/
it( 'Test services block saves with action buttons enabled.', function() {
helpers.addBlockToPost( 'coblocks/services', true );
cy.get( 'div.wp-block-button' ).should( 'not.exist' );
helpers.toggleSettingCheckbox( /display buttons/i );
cy.get( '.wp-block-buttons' ).should( 'have.length', 2 );
helpers.savePage();
helpers.checkForBlockErrors( 'coblocks/services' );
} );

@AnthonyLedesma AnthonyLedesma added this to the Next Release milestone Jun 13, 2024
Copy link
Member

@AnthonyLedesma AnthonyLedesma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. I was not able to break the block, or trigger a deprecation error. Should be good to release.

@AnthonyLedesma AnthonyLedesma changed the title WPEX-3677 remove display button toggle from services block Fix disappearing buttons inside of Services blocks Jun 13, 2024
@AnthonyLedesma AnthonyLedesma merged commit 89c02ac into master Jun 13, 2024
211 checks passed
@AnthonyLedesma AnthonyLedesma deleted the WPEX-3677__coblocks-disappearing-content branch June 13, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants