-
-
Notifications
You must be signed in to change notification settings - Fork 20.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TRACKER] Unit tests to add or improve #43440
Comments
Hi me and a friend would like to take up some of these unit tests for a class project we have. Is there someone we can stay in touch with if we have questions? @Calinou |
@singher Thanks for your interest in contributing! I recommend joining the I also recommend writing a comment here when you're starting to write tests for one class. This way, we can avoid stepping on each other's toes. |
@Calinou perfect! Thank you so much for this opportunity. We will try our best to cover as many of those classes to test. |
I would like to tackle some of the test cases too and would start with the classes Ps.: First time contributor here! |
@MaxMutantMayer it's better to create separate PRs for each class, this eases the review process → potentially speeds up the merging process. 😉 Also, I'd focus on one thing at a time. |
@Xrayez Alright, makes sense. Thanks for clarification |
Noting for posterity that @Calinou found several issues with the JSON facilities not conforming to the spec. He purposely left these unit tests out of the PR to not confuse people, but I created a proposal to address this: godotengine/godot-proposals#1833 |
Hey if you don't mind I'm gonna take a crack at testing geometry 3D, it's also my first time contributing too :D |
I had to write initial test suite for |
Hello, I'm also looking to start contributing and am writing tests for |
I am going to see about writing unit tests for the |
Hey, I opened another PR for |
Hi there! I want to make my first time contribution to the project by writing unit tests for |
Nobody has started work on testing Marshalls yet, but I haven't been able to access that class from C++ since it's mostly intended to be used from GDScript. It might not be easy to test. |
I think it should be possible to test in either case, because core singletons are initialized in the test environment, I don't know exactly what might be a limitation for doing so. For |
Actually I thought about the strategy suggested by @Xrayez:
Anyway, gonna ask you details later here/in Freenode channel. Thanks. |
Hello everyone, interested in making my first contribution with tests for the |
Since we talk about Those are just some considerations if someone hadn't have much luck with testing |
This PR aims to help "fix" godotengine#43440
This PR aims to help "fix" godotengine#43440
This PR aims to help "fix" godotengine#43440
This PR aims to help "fix" godotengine#43440
This PR aims to help "fix" godotengine#43440
This PR aims to help "fix" godotengine#43440
Partially fixes godotengine#43440
This PR aims to help "fix" godotengine#43440
This PR aims to help "fix" godotengine#43440
This PR aims to help "fix" godotengine#43440
The tests test the class getters and setters and the function get aabb. This is what was asked in the issue godotengine#43440.
This PR aims to help "fix" godotengine#43440
This PR aims to help "fix" godotengine#43440 Also fixing a small typo on `SceneMultiplayer` docs.
This PR aims to help "fix" godotengine#43440 Also fixing a small typo on `SceneMultiplayer` docs.
This PR aims to help "fix" godotengine#43440 Also fixing a small typo on `SceneMultiplayer` docs.
This PR aims to help "fix" godotengine#43440
This PR aims to help "fix" godotengine#43440
This PR aims to help "fix" godotengine#43440
This PR aims to help "fix" godotengine#43440
Our unit test coverage is currently fairly low. We'd like to increase our unit test coverage; any help is welcome.
Interested in writing new unit tests? See the unit tests documentation and compiling instructions.
If you have further questions, join the Godot Contributors Chat.
When opening a pull request, please link back to this issue (
#43440
) in the PR description so that we can keep track of it more easily.Classes to test
These classes are currently lacking in test coverage, and are therefore highest-priority for receiving unit tests. Deprecated classes are not listed.
Note
When a class is listed with "and" along a given list item, it should be submitted in the same pull request whenever possible. Tests for these classes can be in the same file or a different file depending on the size and complexity of the test suite. If in doubt, follow the file organization used in the original class implementation.
AnimationPlayer
#92649ui_focus_
actions). This class is complex, so tests for it can be split in multiple pull requests.Decal
#93463HeightMapShape3D
#95123Node3D
#97143bake_scene()
and/orbake_single_node()
. These methods are not currently exposed to the scripting API, but they're still public methods.OptionButton
#93824get_aabb()
.StyleBoxTexture
#95218Completed classes
These classes currently have good test coverage. Further improvements may be possible by testing methods that were added after the tests were merged.
is_position_behind()
and theproject_
/unproject_
methods in particularImageTexture
unit tests #88044Math::
namespace functions #48721Node
tests #71367RandomNumberGenerator
#44560Vector4
/Vector4i
: Add missing methods and tests #64027Non-testable classes
These classes can't be unit-tested for technical reasons. Unit tests always run in headless mode, so they can't do things such as rendering scenes and checking the visual result.
CubeMap:Not testable without RenderingServer access.Shader:Not testable without RenderingServer access.The text was updated successfully, but these errors were encountered: