Add "filesRoot" path to Android provider paths xml #74673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
added
the
cherrypick:3.x
|
The indentation changes seem a bit arbitrary, are they intentional? For the record, your commit seems not to be linked to your GitHub account. See: Why are my commits linked to the wrong user? for more info. |
lewiji
force-pushed
the
android_provider_path
branch
from
ac4b49b
to
ac04ff7
Compare
|
Thanks for the heads up, my IDE must have done something strange there - I've fixed the indentation and the author email. |
m4gr3d
approved these changes
Mar 9, 2023
|
Thanks! |
|
Cherry-picked for 4.0.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
filesRootprovider path to the Android buildgodot_provider_paths.xmlfile.See: #72495 (comment)
This allows custom Android plugins to register the project as a
androidx.core.content.FileProviderfor sharing capabilities in a compatible way with the changes in #72495.@Derektamente has tested it with their Godroid plugin and verified that it works.