Document editor/naming/scene_name_casing setting
#74675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalexeev
reviewed
Mar 9, 2023
| @@ -212,6 +212,9 @@ void register_editor_types() { | |||
| EditorPlugins::add_by_type<Skeleton2DEditorPlugin>(); | |||
| EditorPlugins::add_by_type<Sprite2DEditorPlugin>(); | |||
| EditorPlugins::add_by_type<TilesEditorPlugin>(); | |||
|
|
|||
| // For correct doc generation. | |||
There was a problem hiding this comment.
If it is the correct place, please move these definitions here too.
godot/core/config/project_settings.cpp
Lines 1317 to 1319 in c1128e9
There was a problem hiding this comment.
Will do, see my reasoning above
AThousandShips
force-pushed
the
scene_name_casing
branch
from
a3ea505
to
ecde584
Compare
akien-mga
reviewed
Mar 9, 2023
core/config/project_settings.cpp
Outdated
| @@ -1314,10 +1314,6 @@ ProjectSettings::ProjectSettings() { | |||
|
|
|||
| GLOBAL_DEF(PropertyInfo(Variant::STRING, "editor/script/templates_search_path", PROPERTY_HINT_DIR), "res://script_templates"); | |||
There was a problem hiding this comment.
What about this one, and the two just above?
There was a problem hiding this comment.
Probably a good idea to keep them all together yeah
AThousandShips
force-pushed
the
scene_name_casing
branch
from
ecde584
to
cb721c4
Compare
akien-mga
approved these changes
Mar 9, 2023
|
Seems this one should not be moved due to order of initialization, will put it back as it worked before, though should probably be investigated separately |
Moved definitions of editor related project settings to `editor/register_editor_types.cpp` to make documentation work.
AThousandShips
force-pushed
the
scene_name_casing
branch
from
cb721c4
to
3de5332
Compare
akien-mga
approved these changes
Mar 9, 2023
|
Thanks! |
|
Thank you! |
|
Cherry-picked for 4.0.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved definition to
editor/register_editor_types.cppto make documentation work, there are several ways to achieve this but this is the least obtrusive, adding it toproject_settings.cpprequires includingeditor_node.hwhich felt excessive.