✨ v3 (feature): new mounting system #2022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efectn
reviewed
Aug 18, 2022
|
@balcieren there are some open tasks in the description, is the pull request ready or rather a draft ? can you please update it with the masters |
Actually I am working on v3-alpha branch. I have solved a lot of things about mounting, I am trying to best solution for mounting after that I am gonna fix this pr 👍 |
|
Can you just move mounting to Use since we won't fix sub in sub mounting in this PR. Also can you check the tests and review @balcieren |
efectn
approved these changes
Oct 28, 2022
ReneWerner87
approved these changes
Nov 3, 2022
|
thx @efectn and @balcieren |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inspired by Express