Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golangci-lint to v1.56.1 #2842

Merged
merged 12 commits into from
Feb 13, 2024
2 changes: 1 addition & 1 deletion .github/workflows/linter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,4 @@ jobs:
uses: golangci/golangci-lint-action@v3
with:
# NOTE: Keep this in sync with the version from .golangci.yml
version: v1.55.2
version: v1.56.1
2 changes: 2 additions & 0 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,8 @@ issues:
exclude-use-default: false

linters:
disable:
- spancheck
enable:
- asasalint
- asciicheck
Expand Down
4 changes: 2 additions & 2 deletions app_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -823,7 +823,7 @@
})
ln := fasthttputil.NewInmemoryListener()
go func() {
require.NoError(t, app.Listener(ln))

Check failure on line 826 in app_test.go

View workflow job for this annotation

GitHub Actions / lint

go-require: require must only be used in the goroutine running the test function (testifylint)
}()
time.Sleep(1 * time.Second)
go func() {
Expand Down Expand Up @@ -866,7 +866,7 @@
ln := fasthttputil.NewInmemoryListener()

go func() {
require.NoError(t, app.Listener(ln))
require.NoError(t, app.Listener(ln)) //nolint:testifylint // Needed for test
gaby marked this conversation as resolved.
Show resolved Hide resolved
}()

time.Sleep(1 * time.Second)
Expand Down Expand Up @@ -1543,14 +1543,14 @@
time.Sleep(500 * time.Millisecond)

conn, err := net.Dial(NetworkTCP4, "127.0.0.1:4004")
require.NoError(t, err)
require.NoError(t, err) //nolint:testifylint // Needed for test
defer func(conn net.Conn) {
err := conn.Close()
require.NoError(t, err)

Check failure on line 1549 in app_test.go

View workflow job for this annotation

GitHub Actions / lint

go-require: require must only be used in the goroutine running the test function (testifylint)
}(conn)

_, err = conn.Write([]byte("HEAD /read-timeout HTTP/1.1\r\n"))
require.NoError(t, err)

Check failure on line 1553 in app_test.go

View workflow job for this annotation

GitHub Actions / lint

go-require: require must only be used in the goroutine running the test function (testifylint)

buf := make([]byte, 1024)
var n int
Expand Down
Loading