Limit URL to local site

Signed-off-by: stonezdj <daojunz@vmware.com>
goharbor · Feb 23, 2024 · 03cfb09 · 03cfb09
1 parent 3356196
commit 03cfb09
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/src/core/controllers/oidc.go b/src/core/controllers/oidc.go
@@ -63,7 +63,13 @@ func (oc *OIDCController) RedirectLogin() {
 		oc.SendInternalServerError(err)
 		return
 	}
-	if err := oc.SetSession(redirectURLKey, oc.Ctx.Request.URL.Query().Get("redirect_url")); err != nil {
+	redirectURL := oc.Ctx.Request.URL.Query().Get("redirect_url")
+	if strings.HasPrefix(redirectURL, "//") {
+		log.Errorf("invalid redirect url: %v", redirectURL)
+		oc.SendBadRequestError(fmt.Errorf("cannot redirect to other site"))
+		return
+	}
+	if err := oc.SetSession(redirectURLKey, redirectURL); err != nil {
 		log.Errorf("failed to set session for key: %s, error: %v", redirectURLKey, err)
 		oc.SendInternalServerError(err)
 		return