Skip to content

Commit

Permalink
[cherry-pick] fix: add quote to dockerhub cred in case it contains sp…
Browse files Browse the repository at this point in the history
…ecical characters (#20695)

fix: add quote to dockerhub cred in case it contains specical characters
which will be failed to run the publish release github action job
regarding publishImages

Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
  • Loading branch information
Shengwen YU authored Jul 15, 2024
1 parent 672ec4a commit a3b48a6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/publish_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ jobs:
docker load -i ./harbor/harbor.${{ env.BASE_TAG }}.tar.gz
images="$(docker images --format "{{.Repository}}" --filter=reference='goharbor/*:${{ env.BASE_TAG }}' | xargs)"
source tools/release/release_utils.sh
publishImages ${{ env.CUR_TAG }} ${{ env.BASE_TAG }} ${{ secrets.DOCKER_HUB_USERNAME }} ${{ secrets.DOCKER_HUB_PASSWORD }} $images
publishImages ${{ env.CUR_TAG }} ${{ env.BASE_TAG }} "${{ secrets.DOCKER_HUB_USERNAME }}" "${{ secrets.DOCKER_HUB_PASSWORD }}" $images
publishPackages ${{ env.CUR_TAG }} ${{ env.BASE_TAG }} ${{ github.actor }} ${{ secrets.GITHUB_TOKEN }} $images
- name: Generate release notes
run: |
Expand Down

0 comments on commit a3b48a6

Please sign in to comment.