Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Disable CSRF check for "/c/oidc/onboard" API for authenticating and Onboarding a User via API from Custom CLI #16967

Closed
wants to merge 1 commit into from

Conversation

Rajpratik71
Copy link

@Rajpratik71 Rajpratik71 commented Jun 9, 2022

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #16966

Please indicate you've done the following:

  • [*] Well Written Title and Summary of the PR
  • [*] Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • [*] Accepted the DCO. Commits without the DCO will delay acceptance.
  • [*] Made sure tests are passing and test coverage is added if needed.
  • [*] Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: Pratik Raj rajpratik71@gmail.com

… and Onboarding a User via API from Custom CLI



Closes goharbor#16966
@Rajpratik71 Rajpratik71 requested a review from a team as a code owner June 9, 2022 05:17
@AllForNothing
Copy link
Contributor

AllForNothing commented Jun 9, 2022

@Rajpratik71 Please run git commit --amend -s to signoff to pass the DCO check

Copy link
Member

@Vad1mo Vad1mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, as onboarding is called directly without prior get

@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #16967 (86789da) into main (b8a71ac) will decrease coverage by 23.49%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #16967       +/-   ##
===========================================
- Coverage   67.15%   43.65%   -23.50%     
===========================================
  Files         974      234      -740     
  Lines       81555    12858    -68697     
  Branches     2599     2599               
===========================================
- Hits        54767     5613    -49154     
+ Misses      23057     6938    -16119     
+ Partials     3731      307     -3424     
Flag Coverage Δ
unittests 43.65% <ø> (-23.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...audit-log-purge/history/purge-history.component.ts 49.01% <0.00%> (-9.81%) ⬇️
src/server/middleware/csrf/csrf.go
src/lib/errors/const.go
src/pkg/notifier/notifier.go
src/pkg/proxy/secret/manager.go
src/server/middleware/log/log.go
src/common/models/oidc_user.go
src/pkg/exporter/harbor_cli.go
src/lib/endpoint.go
src/core/auth/oidc/oidc.go
... and 735 more

@AllForNothing AllForNothing added the release-note/enhancement Label to mark PR to be added under release notes as enhancement label Jun 9, 2022
@Rajpratik71
Copy link
Author

Rajpratik71 commented Jun 9, 2022

@AllForNothing @Vad1mo #16969 can be taken as final clean commit.

Let the all tests run here.

Don't pushed here to keep the tests running

@Rajpratik71
Copy link
Author

Also @AllForNothing @Vad1mo

Can we cherry-pick this fix to older release of Harbor

@Rajpratik71
Copy link
Author

@reasonerjt requesting review

@Vad1mo
Copy link
Member

Vad1mo commented Jun 10, 2022

duplicate

@Vad1mo Vad1mo closed this Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/enhancement Label to mark PR to be added under release notes as enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable CSRF check for "/c/oidc/onboard" API for authenticating and Onboarding a User via API from Custom CLI
4 participants