Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix invalid access action #18188

Merged
merged 2 commits into from
May 30, 2023
Merged

fix invalid access action #18188

merged 2 commits into from
May 30, 2023

Conversation

orblazer
Copy link
Contributor

@orblazer orblazer commented Feb 8, 2023

Hello,
This PR fix invalid access action for get repository. This is originally from #16381.

Route impacted :

  • when we get repository via [GET]/projects/{project_name}/repositories/{repository_name} its ask list instead of read

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Thanks.

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #18188 (66e2335) into main (5c42bc1) will increase coverage by 3.11%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18188      +/-   ##
==========================================
+ Coverage   67.38%   70.50%   +3.11%     
==========================================
  Files         980      745     -235     
  Lines      106750    93683   -13067     
  Branches     2665        0    -2665     
==========================================
- Hits        71938    66054    -5884     
+ Misses      30947    24062    -6885     
+ Partials     3865     3567     -298     
Flag Coverage Δ
unittests 70.50% <0.00%> (+3.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/server/v2.0/handler/repository.go 0.00% <0.00%> (ø)

... and 240 files with indirect coverage changes

@MinerYang MinerYang added the release-note/update Update or Fix label Feb 13, 2023
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436
Copy link
Contributor

@YangJiao0817 can you help to test if it impacts the robot account?

Signed-off-by: orblazer <orblazer.minecraft@gmail.com>
@YangJiao0817
Copy link
Member

Verification passed.

@YangJiao0817 YangJiao0817 merged commit b021dbd into goharbor:main May 30, 2023
@OrlinVasilev
Copy link
Member

@orblazer - congrats on merging your first PR :) welcome to the club! :)

WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this pull request Jul 8, 2023
Signed-off-by: orblazer <orblazer.minecraft@gmail.com>
Co-authored-by: Wang Yan <wangyan@vmware.com>
Signed-off-by: Wilfred Almeida <60785452+WilfredAlmeida@users.noreply.github.com>
WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this pull request Jul 8, 2023
Signed-off-by: orblazer <orblazer.minecraft@gmail.com>
Co-authored-by: Wang Yan <wangyan@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants