Changed logic search projects in gitlab adapter #18529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #18529 +/- ##
=======================================
Coverage 67.37% 67.38%
=======================================
Files 984 984
Lines 107029 107027 -2
Branches 2670 2670
=======================================
+ Hits 72116 72117 +1
+ Misses 31031 31030 -1
+ Partials 3882 3880 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
chlins
added
release-note/update
|
@lxShaDoWxl Thanks for your help, the changes look good to me, but let's hold for the verification from user. |
|
@lxShaDoWxl The CI UTTEST failed, please fix it. |
Signed-off-by: lxShaDoWxl <lxshadowxkingxl@gmail.com>
Signed-off-by: lxShaDoWxl <lxshadowxkingxl@gmail.com>
Signed-off-by: lxShaDoWxl <lxshadowxkingxl@gmail.com> (cherry picked from commit 7328062)
Signed-off-by: lxShaDoWxl <lxshadowxkingxl@gmail.com>
WilfredAlmeida
pushed a commit
to WilfredAlmeida/harbor
that referenced
this pull request
Jul 8, 2023
* fix(gitlab): change logic search projects usage search_namespaces Signed-off-by: lxShaDoWxl <lxshadowxkingxl@gmail.com> * tests(gitlab): remove old data and actualization test Signed-off-by: lxShaDoWxl <lxshadowxkingxl@gmail.com> * refactor(gitlab): added debug log Signed-off-by: lxShaDoWxl <lxshadowxkingxl@gmail.com> (cherry picked from commit 7328062) * lint(gitlab): fix import order Signed-off-by: lxShaDoWxl <lxshadowxkingxl@gmail.com> --------- Signed-off-by: lxShaDoWxl <lxshadowxkingxl@gmail.com> Signed-off-by: Wilfred Almeida <60785452+WilfredAlmeida@users.noreply.github.com>
WilfredAlmeida
pushed a commit
to WilfredAlmeida/harbor
that referenced
this pull request
Jul 8, 2023
* fix(gitlab): change logic search projects usage search_namespaces Signed-off-by: lxShaDoWxl <lxshadowxkingxl@gmail.com> * tests(gitlab): remove old data and actualization test Signed-off-by: lxShaDoWxl <lxshadowxkingxl@gmail.com> * refactor(gitlab): added debug log Signed-off-by: lxShaDoWxl <lxshadowxkingxl@gmail.com> (cherry picked from commit 7328062) * lint(gitlab): fix import order Signed-off-by: lxShaDoWxl <lxshadowxkingxl@gmail.com> --------- Signed-off-by: lxShaDoWxl <lxshadowxkingxl@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comprehensive Summary of your change
Changed logic search projects in gitlab adapter for correction search projects
Issue being fixed
Fixes #18284