chore: replace github.com/ghodss/yaml with sigs.k8s.io/yaml
#18606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #18606 +/- ##
==========================================
- Coverage 67.38% 67.36% -0.03%
==========================================
Files 984 984
Lines 107022 107022
Branches 2669 2669
==========================================
- Hits 72118 72094 -24
- Misses 31016 31052 +36
+ Partials 3888 3876 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Vad1mo
approved these changes
Apr 27, 2023
At the time of making this commit, the package `github.com/ghodss/yaml` is no longer actively maintained. `sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively maintained by Kubernetes SIG. Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
WilfredAlmeida
pushed a commit
to WilfredAlmeida/harbor
that referenced
this pull request
Jul 8, 2023
…rbor#18606) At the time of making this commit, the package `github.com/ghodss/yaml` is no longer actively maintained. `sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively maintained by Kubernetes SIG. Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> Co-authored-by: Wang Yan <wangyan@vmware.com> Co-authored-by: MinerYang <yminer@vmware.com> Signed-off-by: Wilfred Almeida <60785452+WilfredAlmeida@users.noreply.github.com>
WilfredAlmeida
pushed a commit
to WilfredAlmeida/harbor
that referenced
this pull request
Jul 8, 2023
…rbor#18606) At the time of making this commit, the package `github.com/ghodss/yaml` is no longer actively maintained. `sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively maintained by Kubernetes SIG. Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> Co-authored-by: Wang Yan <wangyan@vmware.com> Co-authored-by: MinerYang <yminer@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comprehensive Summary of your change
The
github.com/ghodss/yamlpackage is no longer actively maintained.sigs.k8s.io/yamlis a permanent fork ofgithub.com/ghodss/yaml. It is actively maintained by Kubernetes SIG, and also widely used in K8s projects.The notable change is that
github.com/ghodss/yamlusesgopkg.in/yaml.v2 v2.2.2, butsigs.k8s.io/yamlusesgopkg.in/yaml.v2 v2.4.0. Changes can be seen here v2.2.2...v2.4.0, mostly bug fixes.Issue being fixed
Please indicate you've done the following: