Improve zh-tw (Traditional Chinese) locale #18608

PeterDaveHello · 2023-04-26T18:26:56Z

Improve zh-tw (Traditional Chinese) locale

Please indicate you've done the following:

Well Written Title and Summary of the PR
Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
Accepted the DCO. Commits without the DCO will delay acceptance.
Made sure tests are passing and test coverage is added if needed.
Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

pichuang · 2023-04-27T06:46:56Z

As a long-time user of the zh-tw language, I personally recommend this PR.

codecov · 2023-04-27T10:11:50Z

Codecov Report

Merging #18608 (0f541a2) into main (aaea068) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 0f541a2 differs from pull request most recent head 8e622f0. Consider uploading reports for the commit 8e622f0 to get more accurate results

@@            Coverage Diff             @@
##             main   #18608      +/-   ##
==========================================
- Coverage   67.39%   67.37%   -0.02%     
==========================================
  Files         984      984              
  Lines      107029   107029              
  Branches     2670     2670              
==========================================
- Hits        72130    72110      -20     
- Misses      31014    31042      +28     
+ Partials     3885     3877       -8

Flag	Coverage Δ
unittests	`67.37% <ø> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes

AllForNothing · 2023-04-28T07:49:31Z

@PeterDaveHello Thanks for your contribution.
Handling of keys and parameters looks ok. Can you invite someone to help to review your translation?

wy65701436 · 2023-04-29T05:07:19Z

Thank you, @pichuang, for your comments. Please go ahead and add an LGTM. Additionally, we would appreciate another community member who uses the zh-tw language to review it. By the way, I am generally satisfied with these changes.

wy65701436

thanks, LGTM

chlins

lgtm

AllForNothing · 2023-05-05T03:39:11Z

src/portal/src/i18n/lang/zh-tw-lang.json

-    "WAITING_TOO_LONG_3": "For more details, please refer to the ",
-    "WAITING_TOO_LONG_4": "Wiki."
+    "WAITING_TOO_LONG_1": "某些工作等待執行超過 24 小時。請檢查工作服務儀表板。",
+    "WAITING_TOO_LONG_2": "更多詳細資訊，請參考 Wiki。",


"dashboard" and "Wiki" are hyperlink text， so they should be stand-alone items

Updated, thanks.

AllForNothing · 2023-05-05T03:49:46Z

src/portal/src/i18n/lang/zh-tw-lang.json

+    "SCHEDULE": "排程",
+    "TEST_FAILED": "測試失敗",
+    "MANUAL": "手動",
+    "SCHEDULED": "已排程",


This item is used to describe the task type.

Updated, thanks.

Signed-off-by: Peter Dave Hello <hsu@peterdavehello.org>

Improve zh-tw locale Signed-off-by: Peter Dave Hello <hsu@peterdavehello.org> Signed-off-by: Wilfred Almeida <60785452+WilfredAlmeida@users.noreply.github.com>

Signed-off-by: Peter Dave Hello <hsu@peterdavehello.org>

PeterDaveHello · 2023-08-13T18:07:12Z

Hey guys, I sent a follow up of this PR - #19161 to continue the improvement works of zh-tw locale here, would be great to have your reviews, thanks.

Signed-off-by: Peter Dave Hello <hsu@peterdavehello.org>

Update zh-tw (Traditional Chinese) locale, follow up of #18608 Signed-off-by: Peter Dave Hello <hsu@peterdavehello.org>

PeterDaveHello requested a review from a team as a code owner April 26, 2023 18:26

github-actions bot assigned MinerYang, stonezdj and wy65701436 Apr 26, 2023

PeterDaveHello force-pushed the zhtw branch 5 times, most recently from bb3b6a7 to 9670231 Compare April 26, 2023 19:24

MinerYang assigned AllForNothing and unassigned stonezdj and wy65701436 Apr 27, 2023

AllForNothing added release-note/update Update or Fix area/i18n Related to Translation changes. labels Apr 27, 2023

AllForNothing force-pushed the zhtw branch from 9670231 to e56b6c0 Compare April 27, 2023 10:05

wy65701436 approved these changes Apr 29, 2023

View reviewed changes

chlins approved these changes Apr 29, 2023

View reviewed changes

chlins force-pushed the zhtw branch from e56b6c0 to e6032b0 Compare April 29, 2023 14:07

AllForNothing reviewed May 5, 2023

View reviewed changes

Improve zh-tw locale

8e622f0

Signed-off-by: Peter Dave Hello <hsu@peterdavehello.org>

PeterDaveHello force-pushed the zhtw branch from 0f541a2 to 8e622f0 Compare May 5, 2023 11:18

AllForNothing merged commit 0e3e70b into goharbor:main May 8, 2023

PeterDaveHello deleted the zhtw branch May 9, 2023 05:52

PeterDaveHello mentioned this pull request Jun 20, 2023

Add Traditional Chinese zh-tw locale missive/emoji-mart#836

Open

PeterDaveHello added a commit to PeterDaveHello/harbor that referenced this pull request Aug 13, 2023

Update zh-tw (Traditional Chinese) locale, follow up of goharbor#18608

6556fdd

Signed-off-by: Peter Dave Hello <hsu@peterdavehello.org>

PeterDaveHello mentioned this pull request Aug 13, 2023

Update zh-tw (Traditional Chinese) locale #19161

Merged

5 tasks

PeterDaveHello added a commit to PeterDaveHello/harbor that referenced this pull request Aug 13, 2023

Update zh-tw (Traditional Chinese) locale, follow up of goharbor#18608

de7fda9

Signed-off-by: Peter Dave Hello <hsu@peterdavehello.org>

PeterDaveHello added a commit to PeterDaveHello/harbor that referenced this pull request Aug 13, 2023

Update zh-tw (Traditional Chinese) locale, follow up of goharbor#18608

5ccb49b

Signed-off-by: Peter Dave Hello <hsu@peterdavehello.org>

PeterDaveHello added a commit to PeterDaveHello/harbor that referenced this pull request Aug 14, 2023

Update zh-tw (Traditional Chinese) locale, follow up of goharbor#18608

023ffeb

Signed-off-by: Peter Dave Hello <hsu@peterdavehello.org>

PeterDaveHello added a commit to PeterDaveHello/harbor that referenced this pull request Aug 15, 2023

Update zh-tw (Traditional Chinese) locale, follow up of goharbor#18608

4dbb9ab

Signed-off-by: Peter Dave Hello <hsu@peterdavehello.org>

AllForNothing pushed a commit that referenced this pull request Aug 16, 2023

Update zh-tw (Traditional Chinese) locale (#19161)

289d4e2

Update zh-tw (Traditional Chinese) locale, follow up of #18608 Signed-off-by: Peter Dave Hello <hsu@peterdavehello.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve zh-tw (Traditional Chinese) locale #18608

Improve zh-tw (Traditional Chinese) locale #18608

PeterDaveHello commented Apr 26, 2023 •

edited by AllForNothing

Loading

pichuang commented Apr 27, 2023

codecov bot commented Apr 27, 2023 •

edited

Loading

AllForNothing commented Apr 28, 2023

wy65701436 commented Apr 29, 2023

wy65701436 left a comment

chlins left a comment

AllForNothing May 5, 2023

AllForNothing May 5, 2023 •

edited

Loading

PeterDaveHello May 5, 2023

AllForNothing May 5, 2023

PeterDaveHello May 5, 2023

PeterDaveHello commented Aug 13, 2023

Improve zh-tw (Traditional Chinese) locale #18608

Improve zh-tw (Traditional Chinese) locale #18608

Conversation

PeterDaveHello commented Apr 26, 2023 • edited by AllForNothing Loading

pichuang commented Apr 27, 2023

codecov bot commented Apr 27, 2023 • edited Loading

Codecov Report

AllForNothing commented Apr 28, 2023

wy65701436 commented Apr 29, 2023

wy65701436 left a comment

Choose a reason for hiding this comment

chlins left a comment

Choose a reason for hiding this comment

AllForNothing May 5, 2023

Choose a reason for hiding this comment

AllForNothing May 5, 2023 • edited Loading

Choose a reason for hiding this comment

PeterDaveHello May 5, 2023

Choose a reason for hiding this comment

AllForNothing May 5, 2023

Choose a reason for hiding this comment

PeterDaveHello May 5, 2023

Choose a reason for hiding this comment

PeterDaveHello commented Aug 13, 2023

PeterDaveHello commented Apr 26, 2023 •

edited by AllForNothing

Loading

codecov bot commented Apr 27, 2023 •

edited

Loading

AllForNothing May 5, 2023 •

edited

Loading