-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove the notary from backend #18668
Conversation
Codecov Report
@@ Coverage Diff @@
## main #18668 +/- ##
==========================================
+ Coverage 67.36% 67.39% +0.03%
==========================================
Files 984 980 -4
Lines 107018 106749 -269
Branches 2669 2668 -1
==========================================
- Hits 72094 71948 -146
+ Misses 31048 30939 -109
+ Partials 3876 3862 -14
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Since harbor deprecates notary since v2.9.0, this pull request targets to remove the code related with notary. Signed-off-by: Wang Yan <wangyan@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
README.md includes notary desc need to remove |
Since harbor deprecates notary since v2.9.0, this pull request targets to remove the code related with notary. Signed-off-by: Wang Yan <wangyan@vmware.com> Signed-off-by: Wilfred Almeida <60785452+WilfredAlmeida@users.noreply.github.com>
Since harbor deprecates notary since v2.9.0, this pull request targets to remove the code related with notary. Signed-off-by: Wang Yan <wangyan@vmware.com>
PR goharbor#18668 (commit bf7c82b) removed notary, but the source code of migrate-patch and some process in the Makefile for it remained, so remove them. Signed-off-by: Mitsuru Kariya <mitsuru.kariya@nttdata.com>
PR #18668 (commit bf7c82b) removed notary, but the source code of migrate-patch and some process in the Makefile for it remained, so remove them. Signed-off-by: Mitsuru Kariya <mitsuru.kariya@nttdata.com> Co-authored-by: Shengwen YU <yshengwen@vmware.com> Co-authored-by: Wang Yan <wangyan@vmware.com>
PR goharbor#18668 (commit bf7c82b) removed notary, but the source code of migrate-patch and some process in the Makefile for it remained, so remove them. Signed-off-by: Mitsuru Kariya <mitsuru.kariya@nttdata.com> Co-authored-by: Shengwen YU <yshengwen@vmware.com> Co-authored-by: Wang Yan <wangyan@vmware.com> Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
Since harbor deprecates notary since v2.9.0, this pull request targets to remove the code related with notary.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: