Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the notary from backend #18668

Merged
merged 1 commit into from
May 18, 2023
Merged

Conversation

wy65701436
Copy link
Contributor

@wy65701436 wy65701436 commented May 11, 2023

Since harbor deprecates notary since v2.9.0, this pull request targets to remove the code related with notary.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #18668 (4b06c23) into main (845bcdb) will increase coverage by 0.03%.
The diff coverage is 38.88%.

❗ Current head 4b06c23 differs from pull request most recent head 26e2e79. Consider uploading reports for the commit 26e2e79 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18668      +/-   ##
==========================================
+ Coverage   67.36%   67.39%   +0.03%     
==========================================
  Files         984      980       -4     
  Lines      107018   106749     -269     
  Branches     2669     2668       -1     
==========================================
- Hits        72094    71948     -146     
+ Misses      31048    30939     -109     
+ Partials     3876     3862      -14     
Flag Coverage Δ
unittests 67.39% <38.88%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/controller/artifact/controller.go 61.77% <ø> (-0.09%) ⬇️
src/controller/health/checker.go 36.88% <ø> (+2.53%) ⬆️
src/controller/systeminfo/controller.go 62.29% <ø> (-0.61%) ⬇️
src/controller/tag/controller.go 75.20% <ø> (+3.96%) ⬆️
src/core/service/token/creator.go 56.07% <ø> (-5.17%) ⬇️
src/lib/config/systemconfig.go 50.37% <ø> (-1.45%) ⬇️
...ry/artifact/artifact-tag/artifact-tag.component.ts 32.66% <0.00%> (+1.05%) ⬆️
src/server/registry/route.go 0.00% <ø> (ø)
src/server/v2.0/handler/artifact.go 8.73% <0.00%> (+0.09%) ⬆️
src/server/v2.0/handler/model/tag.go 0.00% <ø> (ø)
... and 2 more

... and 10 files with indirect coverage changes

@wy65701436 wy65701436 changed the title [WIP] remove the notary from backend remove the notary from backend May 17, 2023
Since harbor deprecates notary since v2.9.0, this pull request targets to remove the code related with notary.

Signed-off-by: Wang Yan <wangyan@vmware.com>
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj
Copy link
Contributor

README.md includes notary desc need to remove

@wy65701436 wy65701436 merged commit bf7c82b into goharbor:main May 18, 2023
WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this pull request Jul 8, 2023
Since harbor deprecates notary since v2.9.0, this pull request targets to remove the code related with notary.

Signed-off-by: Wang Yan <wangyan@vmware.com>
Signed-off-by: Wilfred Almeida <60785452+WilfredAlmeida@users.noreply.github.com>
WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this pull request Jul 8, 2023
Since harbor deprecates notary since v2.9.0, this pull request targets to remove the code related with notary.

Signed-off-by: Wang Yan <wangyan@vmware.com>
kariya-mitsuru added a commit to kariya-mitsuru/harbor that referenced this pull request Jun 18, 2024
PR goharbor#18668 (commit bf7c82b) removed notary, but the source code of
migrate-patch and some process in the Makefile for it remained, so
remove them.

Signed-off-by: Mitsuru Kariya <mitsuru.kariya@nttdata.com>
@kariya-mitsuru kariya-mitsuru mentioned this pull request Jun 18, 2024
5 tasks
wy65701436 added a commit that referenced this pull request Aug 9, 2024
PR #18668 (commit bf7c82b) removed notary, but the source code of
migrate-patch and some process in the Makefile for it remained, so
remove them.

Signed-off-by: Mitsuru Kariya <mitsuru.kariya@nttdata.com>
Co-authored-by: Shengwen YU <yshengwen@vmware.com>
Co-authored-by: Wang Yan <wangyan@vmware.com>
kunal-511 pushed a commit to kunal-511/harbor_local that referenced this pull request Aug 22, 2024
PR goharbor#18668 (commit bf7c82b) removed notary, but the source code of
migrate-patch and some process in the Makefile for it remained, so
remove them.

Signed-off-by: Mitsuru Kariya <mitsuru.kariya@nttdata.com>
Co-authored-by: Shengwen YU <yshengwen@vmware.com>
Co-authored-by: Wang Yan <wangyan@vmware.com>
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/deprecation Harbor Deprecation MUST need to be in release notes target/2.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants