fix: clean up scan executions and reports after deleting artifact #18693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chlins
assigned wy65701436 and stonezdj and unassigned stonezdj, zyyw and AllForNothing
Codecov Report
@@ Coverage Diff @@
## main #18693 +/- ##
==========================================
- Coverage 67.36% 67.35% -0.02%
==========================================
Files 980 980
Lines 106750 106774 +24
Branches 2665 2665
==========================================
+ Hits 71916 71917 +1
- Misses 30966 30994 +28
+ Partials 3868 3863 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
stonezdj
reviewed
May 19, 2023
chlins
force-pushed
the
fix/on-delete-artifact
branch
2 times, most recently
from
c80fa45
to
33de2de
Compare
Cleanup the associated resources(scan executions and scan reports) after deletion of artifact. Fixes: goharbor#18634 Signed-off-by: chlins <chenyuzh@vmware.com>
chlins
force-pushed
the
fix/on-delete-artifact
branch
from
33de2de
to
572774a
Compare
stonezdj
approved these changes
May 31, 2023
WilfredAlmeida
pushed a commit
to WilfredAlmeida/harbor
that referenced
this pull request
Jul 8, 2023
…harbor#18693) Cleanup the associated resources(scan executions and scan reports) after deletion of artifact. Fixes: goharbor#18634 Signed-off-by: chlins <chenyuzh@vmware.com> Signed-off-by: Wilfred Almeida <60785452+WilfredAlmeida@users.noreply.github.com>
WilfredAlmeida
pushed a commit
to WilfredAlmeida/harbor
that referenced
this pull request
Jul 8, 2023
…harbor#18693) Cleanup the associated resources(scan executions and scan reports) after deletion of artifact. Fixes: goharbor#18634 Signed-off-by: chlins <chenyuzh@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup the associated resources(scan executions and scan reports) after deletion of artifact.
Fixes: #18634
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #18634
Please indicate you've done the following: