Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update text of tooltip, highlight the issue when using cli secrets in #18705

Closed

Conversation

Vad1mo
Copy link
Member

@Vad1mo Vad1mo commented May 19, 2023

This PR adds a bit more context and clarification to the users who are planning to use CLI secrets together with OIDC.

and it goes like this:
The CLI secret can be used as a password, for Docker or Helm client. With the OIDC auth mode enabled, we strongly recommend using robot accounts, as CLI secrets depend on the validity of the ID token and require the user to regularly log in to the UI to refresh the token

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/update"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@Vad1mo Vad1mo requested a review from a team as a code owner May 19, 2023 19:27
combination with OIDC.

Signed-off-by: Vadim Bauer <vb@container-registry.com>
@Vad1mo Vad1mo force-pushed the fix/update_cli_secret_tooltip branch from d092de2 to b31b344 Compare May 19, 2023 19:28
@Vad1mo Vad1mo added release-note/update Update or Fix area/i18n Related to Translation changes. labels May 19, 2023
@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #18705 (d092de2) into main (77df4d9) will increase coverage by 0.79%.
The diff coverage is n/a.

❗ Current head d092de2 differs from pull request most recent head b31b344. Consider uploading reports for the commit b31b344 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18705      +/-   ##
==========================================
+ Coverage   66.57%   67.36%   +0.79%     
==========================================
  Files         998      980      -18     
  Lines      106918   106749     -169     
  Branches     2597     2668      +71     
==========================================
+ Hits        71183    71914     +731     
+ Misses      31817    30977     -840     
+ Partials     3918     3858      -60     
Flag Coverage Δ
unittests 67.36% <ø> (+0.79%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 479 files with indirect coverage changes

Copy link
Contributor

@AllForNothing AllForNothing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AllForNothing
Copy link
Contributor

@Vad1mo Need to rebase the code to rerun all the checks

@AllForNothing
Copy link
Contributor

@Vad1mo Need to rebase
or you can open the edit permission for us then we can help to rebase
image

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AllForNothing
Copy link
Contributor

Closing this one, as the changes in this PR are involved in #18814

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/i18n Related to Translation changes. release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants