-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update text of tooltip, highlight the issue when using cli secrets in #18705
update text of tooltip, highlight the issue when using cli secrets in #18705
Conversation
combination with OIDC. Signed-off-by: Vadim Bauer <vb@container-registry.com>
d092de2
to
b31b344
Compare
Codecov Report
@@ Coverage Diff @@
## main #18705 +/- ##
==========================================
+ Coverage 66.57% 67.36% +0.79%
==========================================
Files 998 980 -18
Lines 106918 106749 -169
Branches 2597 2668 +71
==========================================
+ Hits 71183 71914 +731
+ Misses 31817 30977 -840
+ Partials 3918 3858 -60
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@Vad1mo Need to rebase the code to rerun all the checks |
@Vad1mo Need to rebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Closing this one, as the changes in this PR are involved in #18814 |
This PR adds a bit more context and clarification to the users who are planning to use CLI secrets together with OIDC.
and it goes like this:
The CLI secret can be used as a password, for Docker or Helm client. With the OIDC auth mode enabled, we strongly recommend using robot accounts, as CLI secrets depend on the validity of the ID token and require the user to regularly log in to the UI to refresh the token
Please indicate you've done the following: