Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Angular and Clarity to the latest version #18709

Merged
merged 1 commit into from
May 23, 2023

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented May 22, 2023

1.Upgrade Angular to 16.0.2
2.Upgrade Clarity to 15.4.0

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #18709 (8adc84f) into main (9d042ad) will increase coverage by 22.61%.
The diff coverage is 45.45%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #18709       +/-   ##
===========================================
+ Coverage   44.76%   67.38%   +22.61%     
===========================================
  Files         235      980      +745     
  Lines       13077   106749    +93672     
  Branches     2668     2668               
===========================================
+ Hits         5854    71931    +66077     
- Misses       6931    30957    +24026     
- Partials      292     3861     +3569     
Flag Coverage Δ
unittests 67.38% <45.45%> (+22.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/third-party/ngx-clipboard/clipboard.directive.ts 37.50% <ø> (ø)
...portal/src/app/shared/services/endpoint.service.ts 15.38% <0.00%> (ø)
.../portal/src/app/shared/services/job-log.service.ts 28.57% <0.00%> (ø)
...tal/src/app/shared/services/replication.service.ts 4.87% <0.00%> (ø)
...olvers/artifact-detail-routing-resolver.service.ts 36.36% <100.00%> (ø)
...ting-resolvers/project-routing-resolver.service.ts 17.39% <100.00%> (ø)
...vers/replication-tasks-routing-resolver.service.ts 25.00% <100.00%> (ø)
.../shared/router-guard/auth-user-activate.service.ts 20.00% <100.00%> (ø)
...ared/router-guard/member-guard-activate.service.ts 18.18% <100.00%> (ø)
...-guard/member-permission-guard-activate.service.ts 25.00% <100.00%> (ø)
... and 4 more

... and 750 files with indirect coverage changes

1.Upgrade Angular to 16.0.2
2.Upgrade Clarity to 15.4.0

Signed-off-by: AllForNothing <sshijun@vmware.com>
@AllForNothing AllForNothing merged commit 43c6586 into goharbor:main May 23, 2023
WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this pull request Jul 8, 2023
1.Upgrade Angular to 16.0.2
2.Upgrade Clarity to 15.4.0

Signed-off-by: AllForNothing <sshijun@vmware.com>
Signed-off-by: Wilfred Almeida <60785452+WilfredAlmeida@users.noreply.github.com>
WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this pull request Jul 8, 2023
1.Upgrade Angular to 16.0.2
2.Upgrade Clarity to 15.4.0

Signed-off-by: AllForNothing <sshijun@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants