-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add costomized banner message UI #18827
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllForNothing
requested review from
stonezdj,
wy65701436,
chlins and
YangJiao0817
June 19, 2023 06:39
Codecov Report
@@ Coverage Diff @@
## main #18827 +/- ##
==========================================
+ Coverage 67.38% 67.40% +0.01%
==========================================
Files 981 981
Lines 107072 107188 +116
Branches 2678 2698 +20
==========================================
+ Hits 72149 72248 +99
- Misses 31043 31057 +14
- Partials 3880 3883 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AllForNothing
force-pushed
the
banner
branch
6 times, most recently
from
June 19, 2023 09:01
4537708
to
36c517c
Compare
stonezdj
reviewed
Jun 21, 2023
stonezdj
reviewed
Jun 21, 2023
AllForNothing
force-pushed
the
banner
branch
3 times, most recently
from
June 21, 2023 04:16
ea204db
to
7c19ba0
Compare
stonezdj
approved these changes
Jun 30, 2023
chlins
approved these changes
Jun 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
1.Fixes goharbor#18719 2.Add Banner Message item to configuration 3.Add banner_message property to systeminfo API Signed-off-by: AllForNothing <sshijun@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.Fixes #18719
2.Add Banner Message item to configuration
3.Add banner_message property to systeminfo API
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: