Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support OCI-Subject header #18885

Merged
merged 2 commits into from
Jul 5, 2023
Merged

support OCI-Subject header #18885

merged 2 commits into from
Jul 5, 2023

Conversation

wy65701436
Copy link
Contributor

@wy65701436 wy65701436 commented Jul 4, 2023

the response header OCI-Subject to indicate to the client that the registry processed the request's subject.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #18885 (701012f) into main (1d2624e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18885      +/-   ##
==========================================
+ Coverage   67.37%   67.39%   +0.01%     
==========================================
  Files         981      981              
  Lines      107193   107194       +1     
  Branches     2698     2698              
==========================================
+ Hits        72224    72243      +19     
+ Misses      31088    31066      -22     
- Partials     3881     3885       +4     
Flag Coverage Δ
unittests 67.39% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/server/middleware/subject/subject.go 51.78% <100.00%> (+0.87%) ⬆️

... and 6 files with indirect coverage changes

fixes goharbor#18865
the response header OCI-Subject to indicate to the client that the registry processed the request's subject.

Signed-off-by: wang yan <wangyan@vmware.com>
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit dbaae9e into goharbor:main Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants