Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: * is not allowed in Seconds field of replication cron setting #18922

Closed
wants to merge 1 commit into from

Conversation

zyyw
Copy link
Contributor

@zyyw zyyw commented Jul 12, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)
Resolve task 3 in issue 18091

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@zyyw zyyw added the release-note/update Update or Fix label Jul 12, 2023
@zyyw zyyw requested a review from a team as a code owner July 12, 2023 09:05
@zyyw zyyw assigned wy65701436 and AllForNothing and unassigned Vad1mo Jul 12, 2023
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #18922 (e232d19) into main (98f592f) will decrease coverage by 22.67%.
The diff coverage is n/a.

❗ Current head e232d19 differs from pull request most recent head 05b20a8. Consider uploading reports for the commit 05b20a8 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #18922       +/-   ##
===========================================
- Coverage   67.32%   44.66%   -22.67%     
===========================================
  Files         981      236      -745     
  Lines      107342    13178    -94164     
  Branches     2698     2698               
===========================================
- Hits        72270     5886    -66384     
+ Misses      31189     6996    -24193     
+ Partials     3883      296     -3587     
Flag Coverage Δ
unittests 44.66% <ø> (-22.67%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 748 files with indirect coverage changes

Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
@zyyw zyyw force-pushed the replication-cron-minute-check branch from e232d19 to 05b20a8 Compare July 12, 2023 09:20
@zyyw zyyw changed the title fix: * is not allowed in seconds/minutes of replication cron setting fix: * is not allowed in Seconds field of replication cron setting Jul 12, 2023
@zyyw zyyw closed this Jul 12, 2023
@zyyw zyyw deleted the replication-cron-minute-check branch July 12, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants