Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the configuration for quota update provider #18928

Merged

Conversation

chlins
Copy link
Member

@chlins chlins commented Jul 13, 2023

Add the related configurations for the quota update provider to the harbor.yml.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@chlins chlins added release-note/enhancement Label to mark PR to be added under release notes as enhancement target/2.9.0 labels Jul 13, 2023
@chlins chlins requested a review from a team as a code owner July 13, 2023 08:39
@chlins chlins force-pushed the feat/quota-update-provider-configuration branch from 2b283c3 to 9541a84 Compare July 13, 2023 08:42
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #18928 (9d7efef) into main (c030fd7) will decrease coverage by 3.14%.
The diff coverage is n/a.

❗ Current head 9d7efef differs from pull request most recent head 15fa299. Consider uploading reports for the commit 15fa299 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18928      +/-   ##
==========================================
- Coverage   70.57%   67.43%   -3.14%     
==========================================
  Files         748      993     +245     
  Lines       95339   108772   +13433     
  Branches        0     2747    +2747     
==========================================
+ Hits        67285    73351    +6066     
- Misses      24430    31487    +7057     
- Partials     3624     3934     +310     
Flag Coverage Δ
unittests 67.43% <ø> (-3.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/controller/quota/controller.go 31.77% <ø> (-0.34%) ⬇️

... and 253 files with indirect coverage changes

Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Add the related configurations for the quota update provider to the
harbor.yml.

Signed-off-by: chlins <chenyuzh@vmware.com>
@chlins chlins force-pushed the feat/quota-update-provider-configuration branch from 9d7efef to 15fa299 Compare July 24, 2023 07:19
@chlins chlins merged commit 8ff095d into goharbor:main Jul 24, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/enhancement Label to mark PR to be added under release notes as enhancement target/2.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants