scanner - Do not add unsuported artifacts to scan queue #18931
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Diogo Guerra <diogo.filipe.tomas.guerra@cern.ch>
dioguerra
force-pushed
the
scan-skip-unsupported
branch
from
04d79d4
to
8eca1d2
Compare
|
For reference, the original changes are here: https://github.com/goharbor/harbor/blame/f21b1481bb5ba3efb9e3c1dd8c4e704d9dcc44a1/src/controller/scan/base_controller.go#L181 Maybe i'm missing something @heww ? |
Vad1mo
added
release-note/update
Codecov Report
@@ Coverage Diff @@
## main #18931 +/- ##
==========================================
+ Coverage 67.33% 67.42% +0.08%
==========================================
Files 981 986 +5
Lines 107342 107976 +634
Branches 2698 2698
==========================================
+ Hits 72282 72803 +521
- Misses 31176 31273 +97
- Partials 3884 3900 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
5 tasks
|
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
|
This PR was closed because it has been stalled for 30 days with no activity. If this PR is still relevant, please re-open a new PR against main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
When collectScanningArtifacts is run, the Scannel will return supported bool if the current artifact is scanneable. If it is scaneable this artifact should be added to the artifacts to be scanned and skipped otherwise.
It looks like the artifact might be added to the artifacts to be scanned list even if it is not supported by the remote Scanner.
Issue being fixed
Fixes #(issue)
Not exactly sure it fixes my issue. I dont know how to reproduce, but here is a reference on why I was investigating this:
#18455
/release-note/enhancement
Please indicate you've done the following: