Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add make help cmd #18936

Closed
wants to merge 1 commit into from
Closed

Conversation

yyzxw
Copy link

@yyzxw yyzxw commented Jul 14, 2023

Thank you for contributing to Harbor!

add make help command, result:

image

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: yyzxw <1020938856@qq.com>
@yyzxw yyzxw requested a review from a team as a code owner July 14, 2023 10:33
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #18936 (9bf2d16) into main (ff2b99d) will decrease coverage by 22.72%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #18936       +/-   ##
===========================================
- Coverage   67.39%   44.68%   -22.72%     
===========================================
  Files         986      236      -750     
  Lines      107994    13178    -94816     
  Branches     2698     2698               
===========================================
- Hits        72786     5888    -66898     
+ Misses      31309     6996    -24313     
+ Partials     3899      294     -3605     
Flag Coverage Δ
unittests 44.68% <ø> (-22.72%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 752 files with indirect coverage changes

@yyzxw
Copy link
Author

yyzxw commented Jul 24, 2023

/release-note ignore-for-release

@yyzxw
Copy link
Author

yyzxw commented Jul 24, 2023

/retest

@github-actions
Copy link

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

@github-actions github-actions bot added the Stale label Sep 23, 2023
@github-actions
Copy link

This PR was closed because it has been stalled for 30 days with no activity. If this PR is still relevant, please re-open a new PR against main.

@github-actions github-actions bot closed this Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants