Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh base images on 2.8 #18961

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

YangJiao0817
Copy link
Member

@YangJiao0817 YangJiao0817 commented Jul 20, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: Yang Jiao <jiaoya@vmware.com>
@YangJiao0817 YangJiao0817 added the release-note/infra Infra related changes e.g. release, test, ship etc... label Jul 20, 2023
@YangJiao0817 YangJiao0817 requested a review from a team as a code owner July 20, 2023 06:34
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #18961 (b4a5a83) into release-2.8.0 (46cd4f5) will increase coverage by 25.80%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-2.8.0   #18961       +/-   ##
==================================================
+ Coverage          44.75%   70.55%   +25.80%     
==================================================
  Files                235      749      +514     
  Lines              13089    93936    +80847     
  Branches            2670        0     -2670     
==================================================
+ Hits                5858    66278    +60420     
- Misses              6936    24072    +17136     
- Partials             295     3586     +3291     
Flag Coverage Δ
unittests 70.55% <ø> (+25.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 984 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YangJiao0817 YangJiao0817 merged commit 9269602 into goharbor:release-2.8.0 Jul 20, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants