Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump golang1.20.6 on release-2.8.0& build golang based on photon #18984

Closed
wants to merge 1 commit into from

Conversation

MinerYang
Copy link
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@MinerYang MinerYang added the release-note/update Update or Fix label Jul 24, 2023
@MinerYang MinerYang requested a review from a team as a code owner July 24, 2023 05:04
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #18984 (3bc8420) into release-2.8.0 (9269602) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 3bc8420 differs from pull request most recent head 9478184. Consider uploading reports for the commit 9478184 to get more accurate results

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.8.0   #18984      +/-   ##
=================================================
+ Coverage          67.38%   67.39%   +0.01%     
=================================================
  Files                984      984              
  Lines             107025   107025              
  Branches            2670     2670              
=================================================
+ Hits               72115    72129      +14     
+ Misses             31028    31015      -13     
+ Partials            3882     3881       -1     
Flag Coverage Δ
unittests 67.39% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

@MinerYang MinerYang assigned wy65701436 and unassigned Vad1mo and AllForNothing Jul 24, 2023
Signed-off-by: yminer <yminer@vmware.com>
@MinerYang MinerYang force-pushed the bump_go1.20.6_release-2.8.0 branch from 3bc8420 to 9478184 Compare July 24, 2023 05:37
@MinerYang MinerYang closed this Jul 24, 2023
@MinerYang MinerYang deleted the bump_go1.20.6_release-2.8.0 branch July 26, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants