Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update webhook and replication testcase #18998

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Update webhook and replication testcase #18998

merged 1 commit into from
Jul 25, 2023

Conversation

YangJiao0817
Copy link
Member

@YangJiao0817 YangJiao0817 commented Jul 25, 2023 •
edited
Loading

Sync test case updates because of changes to webhook and replication

  1. fix: replication policy cron setting - the 1st field must be 0; the Minutes field cannot be * #18923
  2. fix: correct the operator in the webhook payload #18906

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@YangJiao0817 YangJiao0817 added area/test automation/nightly-testing release-note/infra Infra related changes e.g. release, test, ship etc... labels Jul 25, 2023
@YangJiao0817 YangJiao0817 requested review from zyyw and chlins July 25, 2023 02:52
@YangJiao0817 YangJiao0817 requested a review from a team as a code owner July 25, 2023 02:52
chlins
chlins approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YangJiao0817
Update webhook and replication testcase
5637915 
Sync test case updates because of changes to webhook and replication
1. goharbor#18923
2. goharbor#18906

Signed-off-by: Yang Jiao <jiaoya@vmware.com>
@YangJiao0817 YangJiao0817 merged commit 7862870 into goharbor:main Jul 25, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyyw zyyw zyyw approved these changes

@chlins chlins chlins approved these changes

Assignees

@zyyw zyyw

@chlins chlins

@YangJiao0817 YangJiao0817

Labels
area/test automation/nightly-testing release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@YangJiao0817 @zyyw @chlins @stonezdj @OrlinVasilev @AllForNothing