Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cron string validation #19071

Merged
merged 2 commits into from
Aug 9, 2023

Merge branch 'main' into cron-string

5897782
Select commit
Loading
Failed to load commit list.
Merged

fix: cron string validation #19071

Merge branch 'main' into cron-string
5897782
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 9, 2023 in 1s

67.41% (+0.00%) compared to 90de909

View this Pull Request on Codecov

67.41% (+0.00%) compared to 90de909

Details

Codecov Report

Merging #19071 (5897782) into main (90de909) will increase coverage by 0.00%.
The diff coverage is 60.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #19071   +/-   ##
=======================================
  Coverage   67.40%   67.41%           
=======================================
  Files         993      993           
  Lines      108812   108864   +52     
  Branches     2751     2751           
=======================================
+ Hits        73347    73392   +45     
- Misses      31526    31527    +1     
- Partials     3939     3945    +6     
Files Changed Coverage Δ
src/server/v2.0/handler/gc.go 2.40% <0.00%> (ø)
src/server/v2.0/handler/purge.go 9.92% <0.00%> (ø)
src/server/v2.0/handler/scan_all.go 86.19% <0.00%> (-1.68%) ⬇️
src/controller/p2p/preheat/controller.go 58.80% <25.00%> (-1.12%) ⬇️
src/controller/retention/controller.go 46.80% <25.00%> (-0.73%) ⬇️
src/common/utils/utils.go 77.93% <100.00%> (+1.43%) ⬆️
src/pkg/p2p/preheat/models/policy/policy.go 75.00% <100.00%> (+1.72%) ⬆️
src/pkg/retention/policy/models.go 28.57% <100.00%> (+11.90%) ⬆️

... and 4 files with indirect coverage changes