Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log: change log level to reduce the noise logs #19146

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

chlins
Copy link
Member

@chlins chlins commented Aug 10, 2023

  1. Change some logs level to reduce the noise.
  2. Wrap the go-redis.Nil error as ErrNotFound to avoid confusing

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@chlins chlins requested a review from a team as a code owner August 10, 2023 03:50
@chlins chlins added the release-note/update Update or Fix label Aug 10, 2023
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #19146 (8517773) into main (d98699b) will increase coverage by 0.02%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19146      +/-   ##
==========================================
+ Coverage   67.40%   67.43%   +0.02%     
==========================================
  Files         993      993              
  Lines      108864   108866       +2     
  Branches     2751     2751              
==========================================
+ Hits        73377    73411      +34     
+ Misses      31539    31511      -28     
+ Partials     3948     3944       -4     
Flag Coverage Δ
unittests 67.43% <57.14%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/core/session/session.go 34.82% <0.00%> (ø)
src/server/registry/manifest.go 66.90% <0.00%> (ø)
src/lib/cache/redis/redis.go 71.30% <100.00%> (-0.38%) ⬇️
src/pkg/notifier/notifier.go 82.35% <100.00%> (ø)

... and 10 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

1. Change some logs level to reduce the noise.
2. Wrap the go-redis.Nil error as ErrNotFound to avoid confusing

Signed-off-by: chlins <chenyuzh@vmware.com>
@chlins chlins merged commit 52e6615 into goharbor:main Aug 17, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants