-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skip transaction for POST /service/token #19339
skip transaction for POST /service/token #19339
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19339 +/- ##
==========================================
- Coverage 45.36% 45.33% -0.03%
==========================================
Files 244 244
Lines 13333 13333
Branches 2720 2720
==========================================
- Hits 6048 6045 -3
- Misses 6984 6987 +3
Partials 301 301
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
408dd29
to
ef3de38
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Habor doesnot support POST /service/token endpoint, put this request into a transaction will consume extra database resources and generate many logs. Signed-off-by: bin liu <liubin0329@gmail.com>
ef3de38
to
d2a089d
Compare
Habor doesnot support POST /service/token endpoint, put this request into a transaction will consume extra database resources and generate many logs. Signed-off-by: bin liu <liubin0329@gmail.com> Signed-off-by: Altynbaev Dinislam <altynbayevdr@sberautotech.ru>
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Habor doesnot support POST /service/token endpoint, put this request into a transaction will consume
extra database resources and generate many logs.
Logs in core and nginx:
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: