subject: fix missing media type recognition for nydus #19453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nydus images are compatible with both docker scheme v2 and OCI image spec v1 types of config media type: - application/vnd.oci.image.config.v1+json - application/vnd.docker.container.image.v1+json The patch fixes the media type recognition on the accessory type check. Signed-off-by: Yan Song <yansong.ys@antgroup.com>
imeoer
force-pushed
the
fix-nydus-media-type
branch
from
0d2ae0f
to
4d2096c
Compare
Codecov Report
@@ Coverage Diff @@
## main #19453 +/- ##
===========================================
- Coverage 70.62% 44.79% -25.83%
===========================================
Files 744 244 -500
Lines 95316 13416 -81900
Branches 0 2752 +2752
===========================================
- Hits 67319 6010 -61309
+ Misses 24356 7100 -17256
+ Partials 3641 306 -3335
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comprehensive Summary of your change
Nydus images are compatible with both docker scheme v2 and OCI image spec v1 types of config media type:
The patch fixes the media type recognition on the accessory type check.
Issue being fixed
Fixes #19452
Please indicate you've done the following: