Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump golang.org/x/net to v0.17.0 && go.opentelemetry.io/contrib on release-2.9.0 #19460

Conversation

MinerYang
Copy link
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #19460 (7e46e5d) into release-2.9.0 (4ca48d9) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.9.0   #19460      +/-   ##
=================================================
- Coverage          67.41%   67.41%   -0.01%     
=================================================
  Files                993      993              
  Lines             108921   108921              
  Branches            2752     2752              
=================================================
- Hits               73430    73424       -6     
- Misses             31541    31546       +5     
- Partials            3950     3951       +1     
Flag Coverage Δ
unittests 67.41% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

Signed-off-by: yminer <yminer@vmware.com>

bump go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp to v0.45.0
@MinerYang MinerYang force-pushed the bump_golang.org/x/net_release-2.9.0 branch from de59c21 to 7e46e5d Compare October 18, 2023 02:15
@MinerYang MinerYang changed the title [cherry-pick] bump golang.org/x/net to v0.17.0 bump golang.org/x/net to v0.17.0 && go.opentelemetry.io/contrib on release-2.9.0 Oct 18, 2023
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MinerYang MinerYang merged commit 1171906 into goharbor:release-2.9.0 Oct 18, 2023
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants