Replace comma in username to avoid casbin issue #19505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #19505 +/- ##
===========================================
- Coverage 67.45% 44.84% -22.61%
===========================================
Files 989 244 -745
Lines 108836 13417 -95419
Branches 2752 2752
===========================================
- Hits 73413 6017 -67396
+ Misses 31462 7094 -24368
+ Partials 3961 306 -3655
Flags with carried forward coverage won't be shown. Click here to find out more. |
stonezdj
force-pushed
the
23oct30_no_comma_username
branch
from
cac40f8
to
1da6af1
Compare
zyyw
reviewed
Oct 31, 2023
zyyw
reviewed
Oct 31, 2023
stonezdj
force-pushed
the
23oct30_no_comma_username
branch
from
1da6af1
to
0eea05e
Compare
zyyw
approved these changes
Oct 31, 2023
Check username when creating user by API Replace comma with underscore in username for OnboardUser Fixes goharbor#19356 Signed-off-by: stonezdj <daojunz@vmware.com>
stonezdj
force-pushed
the
23oct30_no_comma_username
branch
from
0eea05e
to
88ed1b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check username when creating user by API
Replace comma with underscore in username for OnboardUser
Fixes #19356
Signed-off-by: stonezdj daojunz@vmware.com
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: