Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add banner message API test case #19510

Merged

Conversation

YangJiao0817
Copy link
Member

Fix #19271

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@YangJiao0817 YangJiao0817 self-assigned this Oct 31, 2023
@YangJiao0817 YangJiao0817 requested a review from a team as a code owner October 31, 2023 04:46
@YangJiao0817 YangJiao0817 added the release-note/infra Infra related changes e.g. release, test, ship etc... label Oct 31, 2023
@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #19510 (cc3074d) into main (193b00b) will decrease coverage by 22.57%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #19510       +/-   ##
===========================================
- Coverage   67.43%   44.86%   -22.57%     
===========================================
  Files         989      244      -745     
  Lines      108836    13417    -95419     
  Branches     2752     2752               
===========================================
- Hits        73390     6020    -67370     
+ Misses      31482     7093    -24389     
+ Partials     3964      304     -3660     
Flag Coverage Δ
unittests 44.86% <ø> (-22.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 746 files with indirect coverage changes

Fix goharbor#19271

Signed-off-by: Yang Jiao <jiaoya@vmware.com>
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YangJiao0817 YangJiao0817 enabled auto-merge (squash) October 31, 2023 08:22
@YangJiao0817 YangJiao0817 merged commit 2916d09 into goharbor:main Oct 31, 2023
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test automation/pytest-e2e release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add banner message API test case
6 participants